Liviu, Thanks for the quick turnaround on this one! I’ve confirmed the fix in that commit.
Ben Newlin From: Users <users-boun...@lists.opensips.org> on behalf of Liviu Chircu <li...@opensips.org> Reply-To: OpenSIPS users mailling list <users@lists.opensips.org> Date: Wednesday, November 14, 2018 at 11:10 AM To: "users@lists.opensips.org" <users@lists.opensips.org> Subject: Re: [OpenSIPS-Users] OpenSIPS 2.4.3 Rest Client module Many thanks for catching this one, Ben, I just fixed it [1]. This bug breaks all async(rest_post()) and async(rest_put()) calls of the 2.4.3 original release. Maybe we should do another one... Cheers, [1]: https://github.com/OpenSIPS/opensips/commit/fb2aaf65ed993f429b2f12b547dc872aa8632992<https://github.com/OpenSIPS/opensips/commit/fb2aaf65ed993f429b2f12b547dc872aa8632992> Liviu Chircu OpenSIPS Developer http://www.opensips-solutions.com<http://www.opensips-solutions.com> On 14.11.2018 17:53, Liviu Chircu wrote: Hi Ben, Looking into this asap. I did lots of tests for the updated return codes / granular error handling, however I _did not_ assume I could have broken anything in that area. Thanks, Liviu Chircu OpenSIPS Developer http://www.opensips-solutions.com<http://www.opensips-solutions.com> On 14.11.2018 17:04, Ben Newlin wrote: Hello, After upgrading to 2.4.3 I have found that my tests using the REST client module are failing. It seems that some parameters to the rest_post client may have been inadvertently switched. Per the documentation [1], I am passing the body in the second parameter and the content type in the third. async(rest_post("$var(uri)", "$json(resourceRequest)", "$var(send_ctype)", "$var(body)", "$var(recv_ctype)", "$var(rcode)"), resume); But the request being sent out has the body and content type reversed: { "method" : "POST", "path" : "/manager/v1/resources", "headers" : { "Host" : [ "203.0.113.6:1080" ], "Accept" : [ "*/*" ], "Content-Type" : [ "{ \"resources\": 1, \"capabilities\": [ \"sip-service\"" ], "Content-Length" : [ "17" ] }, "keepAlive" : true, "secure" : false, "body" : "application\\/json" } I’ve verified that in 2.4.2 the request is being created properly. [1] https://opensips.org/html/docs/modules/2.4.x/rest_client.html#afunc_rest_post<https://opensips.org/html/docs/modules/2.4.x/rest_client.html#afunc_rest_post> Ben Newlin _______________________________________________ Users mailing list Users@lists.opensips.org<mailto:Users@lists.opensips.org> http://lists.opensips.org/cgi-bin/mailman/listinfo/users<http://lists.opensips.org/cgi-bin/mailman/listinfo/users> _______________________________________________ Users mailing list Users@lists.opensips.org<mailto:Users@lists.opensips.org> http://lists.opensips.org/cgi-bin/mailman/listinfo/users<http://lists.opensips.org/cgi-bin/mailman/listinfo/users>
_______________________________________________ Users mailing list Users@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/users
