I think that generally code reuse is a good idea. ;-) In this case the code even stays within the Apache family, so if anyone cares about my humble opinion, I think it makes sense. As for testing, I think Jason lately talked about Maven's integration test bed. Maybe it makes sense to add an appropriate number of cases to that, if necessary. -- Alexander Kriegisch
> Am 03.06.2014 um 07:53 schrieb Kristian Rosenvold > <[email protected]>: > > I know I have a couple of branches that at least convert all the > plexus-archiver zip stuff to use commons-compress, which is reasonably > simple to plug into plexus-archiver. I have been a bit reluctant to > push these changes since I've been mildly concerned about fallout. I > think it should be fairly simple to convert the remaining > plexus-archiver code to use commons-compress too, including the tar > stuff. > > I am more concerned about the testing aspect of this change, it would > require extensive testing and probably some community effort. Is there > any interest in this ? > > Commons-compress is at least maintained; which is a Good Thing ;) > > > Kristian > > > 2014-06-03 6:20 GMT+02:00 Dan Tran <[email protected]>: >> Looks like it is worth a try to get maven-dependency-plugin having an >> option to use native tar during unpack. >> >> Thanks Jason >> >> -Dan >> >> >> >>> On Mon, Jun 2, 2014 at 6:32 PM, Jason van Zyl <[email protected]> wrote: >>> >>> I have had many problems with Java-based TAR solutions. I often use this >>> where I can: >>> >>> >>> https://github.com/airlift/airship/blob/master/airship-shared/src/main/java/io/airlift/airship/shared/FileUtils.java >>> >>>> On Jun 2, 2014, at 7:15 PM, Dan Tran <[email protected]> wrote: >>>> >>>> BTW, >>>> >>>> I never have good luck with plexus-archiver, and always ended up to >>>> implement my own 'unpack' using native tar to speed up the build and also >>>> reserve the softlinks in the archive. >>>> >>>> So am asking the user list to see if there any interests in this feature >>> to >>>> give enough incentive to implement it >>>> >>>> Thanks >>>> >>>> -D >>>> >>>> >>>> >>>>> On Mon, Jun 2, 2014 at 4:08 PM, Dan Tran <[email protected]> wrote: >>>>> >>>>> Hi Alex, I will find a good sample file for you. >>>>> >>>>> Thanks >>>>> >>>>> -D >>>>> >>>>> >>>>> On Mon, Jun 2, 2014 at 3:57 PM, Alexander Kriegisch < >>>>> [email protected]> wrote: >>>>> >>>>>> Oh, I see, multiple options. Okay, then yes - maintenance nightmare. I >>>>>> think we should not easily give up Java's idea of platform >>> independence and >>>>>> Maven's whole point: creating standardised, repeatable builds. >>>>>> >>>>>> If your idea is a reaction on your latest tar.gz problems, maybe we can >>>>>> find another solution for it. You have not reacted on my offer to >>> inspect >>>>>> your files and see if I have an idea how to fix that in Java. :-) >>>>>> -- >>>>>> Alexander Kriegisch >>>>>> >>>>>> >>>>>>> Am 03.06.2014 um 00:48 schrieb Dan Tran <[email protected]>: >>>>>>> >>>>>>> correct, I would expect user to install tar.exe or cygwin with tar >>> on >>>>>>> windows and activate the option. By default, it still uses >>>>>> plexus-archiver >>>>>>> to unpack >>>>>>> >>>>>>> -D >>>>>>> >>>>>>> >>>>>>> On Mon, Jun 2, 2014 at 3:42 PM, Alexander Kriegisch < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Windows does not have tar by default. You need to install Git (incl. >>>>>> Git >>>>>>>> Bash), Cygwin, GnuWin32 or similar. I would not expect any user to >>>>>> have tar >>>>>>>> installed at all or if so then in any predictable location or even >>>>>>>> reachable via PATH. >>>>>>>> -- >>>>>>>> Alexander Kriegisch >>>>>>>> >>>>>>>> >>>>>>>>> Am 03.06.2014 um 00:36 schrieb Dan Tran <[email protected]>: >>>>>>>>> >>>>>>>>> I am think of enhancing maven-dependency-plugin by adding option to >>>>>>>> unpack >>>>>>>>> 'tar' like artifact using native tar since it is faster and reserve >>>>>> soft >>>>>>>>> links (?) >>>>>>>>> >>>>>>>>> Thoughts? would it be a maintaining night mare?? >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> >>>>>>>>> -Dan >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>> For additional commands, e-mail: [email protected] >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>> >>> Thanks, >>> >>> Jason >>> >>> ---------------------------------------------------------- >>> Jason van Zyl >>> Founder, Apache Maven >>> http://twitter.com/jvanzyl >>> http://twitter.com/takari_io >>> --------------------------------------------------------- >>> >>> To think is easy. To act is hard. But the hardest thing in the world is to >>> act in accordance with your thinking. >>> >>> -- Johann von Goethe > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
