On 9/15/05, Kenney Westerhof <[EMAIL PROTECTED]> wrote:
> It's already working, I don't quite get what you mean? Why would
> you need java code to pass on the properties when they're already
> available?
The ant buildfile is expecting properties. These may or may not match
what is available locally. Somewhere we need to call
target.getProject().setUserProperty( "some.ant.property", myValue );
And then let them propagate w/ inheritall=true
Your AntPropertyHelper is not doing this, but maybe I'm missing something...
> Maybe we can merge your AntFile code to the AntRun plugin, so you
> can either specify nested ant script or refer to some buildfile.
That would be great!!
> M2 already does the chunk of the build.. why would you replicate with ant
> scripts what we've worked so hard for to do with maven itself? :)
You wouldn't -- if Maven could actually do everything -- but Maven is
not a universal tool. It cannot and will not ever do all that people
need in their builds. Sure it might hit 80-90% over time -- but there
will always be those chunks that require customization. All we are
talking about is making that piece easier.
> > So you might have an Ant-based build that you're converting to m2.
> > Let's assume that ~80% is directly convertible to m2, and there are,
> > say, 2 things that are specific to your needs-- at, say, 2 different
> > phases of the Ant build. These should be pulled into 2 m2 plugins that
> > you layer into the general m2 sequence.
>
> .. or just bind the AntRun plugin to these two phases and paste the
> snippets there. Saves you writing 2 plugins. And if you were writing 2
> plugins, why not make them native? Or run the AntTasks directly,
> without people having to specify some scriptlet code (or embedding
> scriptlet code in the plugin..)..?
I want to reuse them. Your suggested approach is not reusable.
>
> True, but the main idea is still: KISS! Say I want a deploy task,
> because Cargo doesn't have a container deploy plugin yet. I just need
> a <copy> tag, 1 line, very simple. It's meant for those things.
> If it gets bigger than a few lines and it's possible to re-use it,
> it should ofcourse go in a separate plugin. But then the question arrises:
> create an ant script and wrap a m2 plugin around that to configure the
> script, or just create a pure Mojo?
>
> But, ofcourse I see the benefits of this (else the antrun plugin
> probably wouldn't have existed), but I'm afraid if everybody can do it
> with ant, they won't take the time to write a great maven2 plugin that's
> far more reusable than a customized ant script.
Sorry Kenney, but I don't get it. As Ashley said, to the plugin user
there is no difference between the two approaches. But to the plugin
writer there certainly is.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
