On 1/15/06, Sasvata Chatterjee <[EMAIL PROTECTED]> wrote: > > On 1/15/06, Brian E. Fox <[EMAIL PROTECTED]> wrote: > > I think he means add it to the plexus archiver so that it can be easily > > implemented where the archiver is used. > > > It would be nice for reusability if it were in Plexus. But, there are > some gotchas: > > - I haven't looked through all of Plexus. Is there something > equivalent to org.codehaus.maven.model.PatternSet in Plexus? > Otherwise, a Maven dep. needs to be added to Plexus (or, I guess, the > equivalent of PattrnSet must be added to Plexus). > > - There's no way to extend the UnArchiver interface without affecting > all implementations (outside of Plexus) that implement the interface. > Only backwards-compatible way is to create a new interface extending > UnArchiver, but then it is a new interface anyway....
Can we just add setExcludes() and setIncludes() to the unarchiver interface? And make other unarchiver implementations includes and excludes aware? (note gzip unarchiver will not understand this) And there all clients of plexus unarchiver does not have to change, but can use the new features when ever convinient. Anyway, I am only a user of Maven and indirectly Plexus, so I am not > really sure of the design choices that need to be made. The code is > here, let me know which makes most sense and I'll file a JIRA > accordingly. > > Shash > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
