This did not work.  It still does not pick up

<configuration>
  <skip>true</skip>
</configuration>

in the integration test phase.

Anyone else?  I have created a JIRA issue about this:

http://jira.codehaus.org/browse/MNG-1969


Note that when I tried your suggestion:

/**
 * Should these tests be skipped?
 * @parameter expression="skip" default-value="true"
 */
private boolean skip;

The "skip" value was still "false".  Setting it in the pom file had zero
effect.

If instead I did it the other way:

/**
 * Should these tests be skipped?
 * @parameter expression="true"
 */
private boolean skip;

At least the value of "true" was set on my variable, though I still can
not change the value with my pom.

BTW, all this is with 2.0.2

John Wells (Aziz)
[EMAIL PROTECTED]

-----Original Message-----
From: dan tran [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, January 17, 2006 9:45 AM
To: Maven Users List
Subject: Re: [M2] Configuration parameters for my Mojo(s)

@parameter expression="skip" default-value="false"

would fix the problem.



On 1/17/06, John Wells <[EMAIL PROTECTED]> wrote:
>
> Does anyone have any help for me here?
>
> The basic problem is that my Mojo is not getting configured from the
> pom.xml file during the integration-test phase.  The details are
below.
> Someone please help!!!
>
> John Wells (Aziz)
> [EMAIL PROTECTED]
>
> -----Original Message-----
> From: John Wells
> Sent: Monday, January 16, 2006 7:54 AM
> To: Maven Users List
> Subject: RE: [M2] Configuration parameters for my Mojo(s)
>
> OK,
>
> I just found something else out:
>
> If instead I change the last "execution" for the plugin to be for
phase
> "package", then my variables get set properly.  So, if my pom.xml
> instead has this:
>
> <execution>
> <id>integration-test</id>
> <phase>package</phase>
> <goals>
>    <goal>run-osgi-test</goal>
> </goals>
> <configuration>
>    <skip>true</skip>
> </configuration>
> </execution>
>
> The problem with this is that my run-osgi-test then properly picks up
> the variables in the "packaging" phase but then goes ahead and runs
with
> the variables not set in the "integration-test" phase.
>
> I'm fairly sure there is a real maven bug here.
>
> It seems like the "configurator" is not working in the
integration-test
> phase.
>
> John Wells (Aziz)
> [EMAIL PROTECTED]
>
>
> -----Original Message-----
> From: John Wells
> Sent: Monday, January 16, 2006 7:45 AM
> To: Maven Users List
> Subject: [M2] Configuration parameters for my Mojo(s)
>
> I have a plugin that defines a new packaging type.  This is basically
> the same as the jar packaging type, except it does nothing in the test
> phase, has a special packaging phase (where some manifest entries are
> added) and an integration-test phase that runs an integration test.
>
> I am able to modify parameters in the "packaging" phase with no
problem.
> However, in the integration-test phase, for some reason, my parameters
> are not getting set from the pom.xml.  Here is the XML snippet from my
> pom.xml:
>
>      <plugin>
>        <groupId>com.bea.core.maven2.plugins</groupId>
>        <artifactId>maven-osgi-bundler-plugin</artifactId>
>        <version>1.0.0-SNAPSHOT</version>
>        <extensions>true</extensions>
>        <executions>
>          <execution>
>            <id>main</id>
>            <phase>package</phase>
>            <goals>
>              <goal>osgi-bundle</goal>
>            </goals>
>            <configuration>
>
> <bundleActivator>com.bea.jetty.JettyActivator</bundleActivator>
>              <bundleName>Jetty HTTP</bundleName>
>              <bundleDescription>OSGi HTTP service using
> Jetty</bundleDescription>
>
> <bundleSymbolicName>com.bea.core.jetty</bundleSymbolicName>
>              <importPackages>
>                <importPackage>org.osgi.framework</importPackage>
>                <importPackage>org.osgi.service.log</importPackage>
>                <importPackage>com.bea.core.dioce</importPackage>
>                <importPackage>com.bea.core.netio</importPackage>
>                <importPackage>com.bea.core.wm</importPackage>
>              </importPackages>
>              <exportPackages>
>
<exportPackage>javax.servlet;version=2.5</exportPackage>
>
> <exportPackage>javax.servlet.http;version=2.5</exportPackage>
>
> <exportPackage>org.osgi.service.http;version=1.2</exportPackage>
>              </exportPackages>
>              <bundleClasspaths>
>                <bundleClasspath>.</bundleClasspath>
>                <bundleClasspath>lib/http-service.jar</bundleClasspath>
>                <bundleClasspath>lib/servlet.jar</bundleClasspath>
>              </bundleClasspaths>
>            </configuration>
>          </execution>
>          <execution>
>            <id>test</id>
>            <phase>package</phase>
>            <goals>
>              <goal>test-osgi-bundle</goal>
>            </goals>
>            <configuration>
>
> <bundleActivator>com.bea.jetty.test.TestActivator</bundleActivator>
>              <bundleName>Jetty HTTP Tests</bundleName>
>              <bundleDescription>OSGi HTTP service using Jetty Testing
> Bundle</bundleDescription>
>
> <bundleSymbolicName>com.bea.core.jetty.tests</bundleSymbolicName>
>              <importPackages>
>                <importPackage>org.osgi.framework</importPackage>
>                <importPackage>javax.servlet</importPackage>
>                <importPackage>javax.servlet.http</importPackage>
>                <importPackage>org.osgi.service.http</importPackage>
>              </importPackages>
>            </configuration>
>          </execution>
>          <execution>
>            <id>integration-test</id>
>            <phase>integration-test</phase>
>            <goals>
>              <goal>run-osgi-test</goal>
>            </goals>
>            <configuration>
>              <skip>true</skip>
>            </configuration>
>          </execution>
>        </executions>
>      </plugin>
>
>
> With no problem at all the various variables I set in the "packaging"
> phase are being set.  There are two mojo's there, with the goals
> osgi-bundle and test-osgi-bundle.  Both of those things seem to be
> getting their configuration parameters just fine from the pom.xml.
>
> However, my run-osgi-test goal that happens from the integration-test
> phase is NOT getting the configuration parameter.
>
> Here is the output from "mvn -X integration-test" (well, some of
it)...
>
> [DEBUG] Configuring mojo
> 'com.bea.core.maven2.plugins:maven-osgi-bundler-plugin:
> 1.0.0-SNAPSHOT:run-osgi-test' -->
> [DEBUG]   (f) buildDirectory =
C:\weblogic\dev\core\modules\jetty\target
> [DEBUG]   (f) integrationDirectoryName = integration-test
> [DEBUG]   (f) loadFileName = loader.xml
> [DEBUG]   (f) project = [EMAIL PROTECTED]
> [DEBUG]   (f) skip = false
> [DEBUG]   (f) testTimeout = 300000
>
>
> Etc.  At this point, shouldn't "skip" be "true" since I set it to
"true"
> in the pom.xml?
>
> Here is the java:
>
> /**
> * Should these tests be skipped?
> * @parameter expression="false"
> */
> private boolean skip;
>
>
> I have tried several things:
>
> 1) Making it a "String" rather than a Boolean
> 2) Moving it to the same package as the other mojo's that *are*
getting
> their variables configured properly
> 3) Having multiple "plugin" definitions in the pom file
>
> Any help would be appreciated.
>
> John Wells (Aziz)
> [EMAIL PROTECTED]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to