David, you are way overcomplicating the cobertura setup.  Remove your
executions and the surefire config.  There's no need - all this is
handled internally when the plugin executes with 'cobertura:cobertura'.

  _____  

From: David Sag [mailto:[EMAIL PROTECTED] 
Sent: Monday, February 20, 2006 7:20 AM
To: Maven Users List
Subject: Re: cobertura plugin



Interesting 

the main difference between the way you do it and the way I am doing is
that I specify the goal and execution phase in my build declarations
thusly: 

     <plugin> 
        <groupId>org.codehaus.mojo</groupId> 
        <artifactId>cobertura-maven-plugin</artifactId> 
        <version>2.0-SNAPSHOT</version> 
        <executions> 
          <execution> 
            <id>instrument-classes</id> 
            <phase>process-classes</phase> 
            <goals> 
              <goal>instrument</goal> 
            </goals> 
          </execution> 
        </executions> 
      </plugin>

could this be causing my problem?  i doubt it. 

Also I explicitly tell surefire where the instrumented classes are: 

      <!-- run the unit tests on the cobertura instrumented classes --> 
      <plugin> 
        <artifactId>maven-surefire-plugin</artifactId> 
        <version>2.0</version> 
        <configuration> 
 
<classesDirectory>${project.build.directory}/classes-instrumented</class
esDirectory> 
        </configuration> 
      </plugin> 

otherwise we are doing pretty much the same thing. 

I can't see in your pom.xml how your tests know to run the instrumented
classes, nor is it obvious in what phase you are instrumenting your
classes.  what sort of coverage reports are you getting? 

Kind regards,
Dave Sag 




  

"javed mandary" <[EMAIL PROTECTED]> wrote on 20-02-2006 13:57:41:

> Am running maven site with cobertura report generation:
> 
> <?xml version="1.0" encoding="UTF-8"?>
> <project>
> [.....]
>     <build>
>             <resources>
>               <resource>
>                 <directory>src/main/resources</directory>
>                 <includes>
>                   <include>*.xls</include>
>                   <include>**/*.xml</include>
>                   <include>*.properties</include>
>                 </includes>
>               </resource>
>             </resources>
>                <plugins>
>                     <plugin>
>                        <groupId>org.codehaus.mojo</groupId>
>
<artifactId>surefire-report-maven-plugin</artifactId>
>                        <version>2.0-beta-1</version>
>                        <configuration>
>                           <testFailureIgnore>true</testFailureIgnore>
>                        </configuration>
>                     </plugin>
>                     <plugin>
>                             <groupId>org.codehaus.mojo</groupId>
>
<artifactId>cobertura-maven-plugin</artifactId>
>                             <version>2.0-SNAPSHOT</version>
>                    </plugin>
>               </plugins>
>       </build>
>       <reporting>
>       <plugins>
>           <plugin>
>                    <groupId>org.codehaus.mojo</groupId>
>
<artifactId>surefire-report-maven-plugin</artifactId>
>                    <version>2.0-beta-1</version>
>          </plugin>
>         <plugin>
>                     <groupId>org.codehaus.mojo</groupId>
>                     <artifactId>cobertura-maven-plugin</artifactId>
>                     <version>2.0-SNAPSHOT</version>
>           </plugin>
>       </plugins>
>     </reporting>
> 
>     <dependencies>
>     <dependency>
>       <groupId>asm</groupId>
>       <artifactId>asm</artifactId>
>       <version>1.5.3</version>
>     </dependency>
>         <dependency>
>             <groupId>org.springframework</groupId>
>             <artifactId>spring-mock</artifactId>
>             <version>1.2.6</version>
>             <scope>test</scope>
>             <exclusions>
>                 <exclusion>
>                     <artifactId>jta</artifactId>
>                     <groupId>javax.transaction</groupId>
>                 </exclusion>
>                 <exclusion>
>                     <artifactId>jdbc-stdext</artifactId>
>                     <groupId>javax.sql</groupId>
>                 </exclusion>
>                 <exclusion>
>                     <artifactId>jsf-api</artifactId>
>                     <groupId>javax.faces</groupId>
>                 </exclusion>
>             </exclusions>
>         </dependency>
>         <dependency>
>             <groupId>org.springframework</groupId>
>             <artifactId>spring-remoting</artifactId>
>             <version>1.2.6</version>
>         </dependency>
>         <dependency>
>             <groupId>org.springframework</groupId>
>             <artifactId>spring-core</artifactId>
>             <version>1.2.6</version>
>         </dependency>
>         <dependency>
>             <groupId>axis</groupId>
>             <artifactId>axis</artifactId>
>             <version>1.2.1</version>
>             <exclusions>
>                 <exclusion>
>                     <artifactId>activation</artifactId>
>                     <groupId>javax.activation</groupId>
>                 </exclusion>
>                 <exclusion>
>                     <artifactId>mail</artifactId>
>                     <groupId>javax.mail</groupId>
>                 </exclusion>
>             </exclusions>
>         </dependency>
>         <dependency>
>             <groupId>axis</groupId>
>             <artifactId>axis-jaxrpc</artifactId>
>             <version>1.2.1</version>
>         </dependency>
>         <dependency>
>             <groupId>axis</groupId>
>             <artifactId>axis-saaj</artifactId>
>             <version>1.2.1</version>
>         </dependency>
> 
>     </dependencies>
> </project>
> 
> On 2/20/06, David Sag <[EMAIL PROTECTED]> wrote:
> >
> >
> > I guess we are having different problems.  In a reply to my Jira
issue
> > Carlos Sanchez points out that my problem lies in the fact that
cobertura is
> > trying to instrument the classes twice.  I am not sure why this is
> > happening, nor am i sure why this is even a problem, but clearly you
are not
> > getting this problem.
> >
> > could you show me your pom.xml so i can look for any obvious
differences
> > between what you are doing and what I am doing.
> >
> > Kind regards,
> > Dave Sag
> >
> >
> >
> >
> >
> >
> > "Brett Porter" <[EMAIL PROTECTED]> wrote on 20-02-2006
09:05:19:
> >
> > > this problem was fixed in SVN (asm is no longer propogated to
tests
> > > themselves)
> > >
> > > On 2/20/06, javed mandary <[EMAIL PROTECTED]> wrote:
> > > > Hi David,
> > > >              I solved the problem with the Cobertura plugin
running
> > > > hibernate junit tests by adding the following dependency in my
POM:
> > > >
> > > >     <dependency>
> > > >       <groupId>asm</groupId>
> > > >       <artifactId>asm</artifactId>
> > > >       <version>1.5.3</version>
> > > >     </dependency>
> > > >
> > > >
> > > > It seems that Cobertura is looking for  asm-2.1 in its POM while
> > hibernate
> > > > requires asm-1.5.3.
> > > >
> > > > By setting the dependency asm-1.5.3 , this is placed in
classpath and
> > > > everything works fine , cobertura site report is generated
> > successfully.
> > > >
> > > > regards,
> > > >       Javed
> > > >
> > > >
> > > >
> > > > On 2/17/06, David Sag <[EMAIL PROTECTED]> wrote:
> > > > >
> > > > >
> > > > > Maven 2 is what I am on about.  see the jira issue, but i am
getting
> > the
> > > > > same problem as you describe.  perhaps you'd like to vote on
> > > that issue and
> > > > > add your comments there.
> > > > >
> > > > > Kind regards,
> > > > > Dave Sag
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > "javed mandary" <[EMAIL PROTECTED]> wrote on 17-02-2006
14:14:17:
> > > > >
> > > > > > ok , what about the cobertura plugin for maven 2 ? In maven
site I
> > am
> > > > > > getting a problem after cobertura runs the junit tests and
tryto
> > create
> > > > > a
> > > > > > report it crashes and fails the build.
> > > > > >
> > > > > > Has anyone got similar problems and any solutions to that?
> > > > > >
> > > > > > this is what i am using:
> > > > > > <plugin>
> > > > > >                 <groupId>org.codehaus.mojo</groupId>
> > > > > >
<artifactId>cobertura-maven-plugin</artifactId>
> > > > > >                 <version>2.0-SNAPSHOT</version>
> > > > > >                 <executions>
> > > > > >                   <execution>
> > > > > >                     <goals>
> > > > > >                       <goal>clean</goal>
> > > > > >                     </goals>
> > > > > >                   </execution>
> > > > > >                 </executions>
> > > > > >             </plugin>
> > > > > >
> > > > > > regards,
> > > > > >       Javed
> > > > > >
> > > > > > On 2/17/06, David Sag <[EMAIL PROTECTED]> wrote:
> > > > > > >
> > > > > > >
> > > > > > > Hi Brett
> > > > > > >
> > > > > > > I have files jira issue http://jira.codehaus.
> org/browse/MOJO-299and
> > > > > > > included an example project that displays the bug.
> > > > > > >
> > > > > > > if you could put your repo manager code somewhere in a zip
file
> > I can
> > > > > try
> > > > > > > it out here and see if I get the same problems.
> > > > > > >
> > > > > > > Kind regards,
> > > > > > > Dave Sag
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on 17-02-2006
> > 13:33:08:
> > > > > > >
> > > > > > > > Hi David,
> > > > > > > >
> > > > > > > > There might be a release coming up, but we haven't
worked on
> > your
> > > > > issue
> > > > > > > and
> > > > > > > > there are still some other issues outstanding that
should be
> > fixed
> > > > > > > first.
> > > > > > > >
> > > > > > > > If you could confirm that cobertura fails for you on the
> > repository
> > > > > > > manager
> > > > > > > > app (if SVN is a problem I can upload it somewhere),
that
> > would
> > > > > isolate
> > > > > > > it
> > > > > > > > to you environment over your particular project.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Brett
> > > > > > > >
> > > > > > > > On 2/17/06, David Sag <[EMAIL PROTECTED]> wrote:
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Sorry brett the last i heard from you was that you
were
> > working on
> > > > > the
> > > > > > > > > problem and there would be a release late this week.
> > > > > > > > >
> > > > > > > > > So I have been working on other things and waiting
> > paitiently.
> > > > > > > > >
> > > > > > > > > But if you are now telling me I need to file a jira
issue
> > then
> > > > > that's
> > > > > > > what
> > > > > > > > > i'll do.
> > > > > > > > >
> > > > > > > > > I'll have to put together a minimal project and
reproduce
> > the
> > > > > problem
> > > > > > > in
> > > > > > > > > some code that is not the EPOs tho.  This probably
won't
> > happen
> > > > > today.
> > > > > > > > >
> > > > > > > > > Kind regards,
> > > > > > > > > Dave Sag
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Brett Porter <[EMAIL PROTECTED]> wrote on
17-02-2006
> > > > > 13:20:42:
> > > > > > > > >
> > > > > > > > > > On 2/17/06, David Sag <[EMAIL PROTECTED]> wrote:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > Sorry are you talking about maven 1 or 2 plugin?
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > They are talking about Maven 1.0
> > > > > > > > > >
> > > > > > > > > > I was told that 2.0-SNAPSHOT is the one to use for
maven 2
> > but
> > > > > since
> > > > > > > > > > > updating to maven 2.0.2 the reporting part of
cobertura
> > hasn't
> > > > > > > worked.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > I can't reproduce it. If it never gets filed in
JIRA,
> > it'll
> > > > > never
> > > > > > > get
> > > > > > > > > > fixed... can you please do that at
> > > > > > > http://jira.codehaus.org/browse/MOJO?
> > > > > > > > > >
> > > > > > > > > > Did you try the repository manager example I showed
you
> > last
> > > > > time
> > > > > > > that
> > > > > > > > > is
> > > > > > > > > > working for me?
> > > > > > > > > >
> > > > > > > > > > - Brett
> > > > > > > > >
> > > > > > >
> > > > >
> > > >
> > > >
> > >
> > >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> >

Reply via email to