Yes you should. +1. I would rather wait another week or two or three for a new feature with user docs than have the current path of docs not materializing often enough.
And reject same for no tests. Code + tests + docs = valid contribution. Make your stance, clearly document this on the "How to Contribute" page. Reject away. -----Original Message----- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Monday, March 06, 2006 11:55 PM To: Maven Users List Subject: Re: Maven documentation (was Re: how to include all dependencies in your jar) > You don't have that problem if everyone documents what they contribute. So.. we should knock back contributions without documentation? you should see the reaction we get when we try that! Ideally, every contribution should have docs and tests. But I don't think its reasonable to knock it back without it (we should be asking more persistently though, and above all doing it ourselves). This still doesn't address the problem that the developers perception of what is required to understand it is different from everyone else's. It needs iterative improvement. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
