I went ahead and fixed the issue. It builds and runs successfully on windows as well as mac. Please let me know if you see any issues. Thanks, Sangjin
2008/4/15 Sangjin Lee <[EMAIL PROTECTED]>: > Considering the current semantics of sessionCreated(), a valid test is > really a regex match against "12?3". :) Care to file a bug? > Thanks, > Sangjin > > > 2008/4/15 Simon Trudeau <[EMAIL PROTECTED]>: > > Yep, that's exactly what I see. > > > > > > Simon > > -----Original Message----- > > From: Sangjin Lee [mailto:[EMAIL PROTECTED] > > Sent: April-15-08 2:53 AM > > To: [email protected]; 이희승 (Trustin Lee) > > Subject: Re: Test failure for trunk revision 646772 under windows xp > > 32-bit single processor machine > > > > I do see the test failures on my windows box too. > > > > The error message is as follows: > > junit.framework.ComparisonFailure: null expected:<1[2]3> but was:<1[]3> > > at junit.framework.Assert.assertEquals(Assert.java:81) > > at junit.framework.Assert.assertEquals(Assert.java:87) > > at > > > > org.apache.mina.transport.AbstractConnectorTest.testConnectFutureSuccessTiming(AbstractConnectorTest.java:79) > > > > It seems to me that this is a race between sessionOpened() and the > > ConnectFuture getting completed. > > > > In IoServiceListenerSupport.fireSessionCreated() we have > > > > session.getFilterChain().fireSessionCreated(); > > session.getFilterChain().fireSessionOpened(); > > > > The ConnectFuture gets completed as part of the fireSessionCreated() > > call. > > Therefore, it seems there is no guarantee that sessionOpened() will fire > > before the future gets completed. > > > > It seems that it was a conscious decision to complete the connect future > > before calling sessionOpened(). Then perhaps these tests are no longer > > valid as there is no such guarantee? > > > > Thanks, > > Sangjin > > > > > > On Sun, Apr 13, 2008 at 7:21 PM, "이희승 (Trustin Lee) <[EMAIL PROTECTED]> > > wrote: > > > > > Hi Simon, > > > > > > Please post the detailed failure message, because it simply works in > > > my machine. > > > > > > Simon Trudeau wrote: > > > > I would like to report that the following test fail for trunk > > > > revision > > > > 646772 under windows xp 32 bit single on a single processor machine. > > > > They successfull pass on windows vista sp1 32 bit on a dual core > > > > machine. > > > > > > > > Failed tests: > > > > > > > > testConnectFutureSuccessTiming(org.apache.mina.transport.socket.nio. > > > > Sock > > > > etConnectorTest) > > > > > > > > testConnectFutureSuccessTiming(org.apache.mina.transport.socket.nio. > > > > Data > > > > gramConnectorTest) > > > > > > > > Simon > > > > > > > > > > > > > > -- > > > Trustin Lee - Principal Software Engineer, JBoss, Red Hat > > > -- > > > what we call human nature is actually human habit > > > -- > > > http://gleamynode.net/ > > > > > > > > > >
