Barrie Treloar wrote:
I wanted to write a unit test that showed
AbstractPollingIoProcessor.write() threw an exception that the
WriteFuture doesn't get notified.
But all the places I would sneak in such a change for testing have been denied.
The classes I want to modify are final or the methods I want to modify
are final.
Yeah, they are final to (supposely) protect the developper from
mis-using them in an extended method (which seems to me a bad choice, to
some extent : either the user is 'educated' or not, in any case, those
who want to extend those classes know what they are doing !). We may
reconsider that
Am I just missing something?
Looking at a lot of unit tests they are only testing "happy days" scenarios.
Exceptional flows don't seem to be checked.
That's so true :(
But anyone who want to add some 'real life' test, ie tests that check
the code against bad conditions, is very welcome to post some patches !
All in all, this is the way MINA will progress :)
Many thanks !
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
