Hmmmm, I see the code in question, but I'm not sure I can test it. I've got an old svn checkout, that I thought was M4-ish in timeframe. But when I build it it's calling itself RC2. I doubt my application will link to RC2, we've been using M4; tried M5 but it caused so many problems that we dropped back to M4 and decided to wait for a real release before updating again.

In looking at the code I'm thinking it's not the conditional, so much as the need to fire the message sent event on every write?

boB


Christopher Popp wrote:
I see it didn't  keep my red highlighting...but regardless, it shouldn't take too 
long looking at the method to see that the event is not propagated correctly to 
the filters.  It looks slightly more complicated than changing from == to >= 
actually, but it shouldn't be too bad for someone who has the serial stuff setup 
already.

It looks like SerialSessionImpl.java is the class that actually handles reading 
and writing for serial data.
There is one place where it fires the messageSent event.  However, it looks like 
the equality check prevents it from actually firing that event to the filters 
unless the buffer is empty...I'm guess the == should instead be >=.
See below for the method, with the pertintent lines in red.  I haven't actually 
tried changing this and seeing if it allows writes to be logged, but it seems 
like it could be the problem.

Christopher Popp

Christopher Popp



Reply via email to