Great :) Can you close https://issues.apache.org/jira/browse/DIRMINA-740 ? Julien
Le Mon, 12 Oct 2009 10:20:56 -0400, boB Gage <[email protected]> a écrit : > Thanks!! It looks like the first fix got it. Took a little > longer to test than I'd hoped (I'm doing this all remotely and > someone turned off the device I'm monitoring for the weekend... ) > > I have data flowing now from the hardware flow controlled device as > well as the no-flow control devices. > > Thanks again!!! > boB > > > Julien Vermillard wrote: > > I added methods in SerialSession for manipulating DTR/RTS lines > > > > here the patches : > > > > http://svn.apache.org/viewvc/mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSession.java?r1=824254&r2=824255&pathrev=824255&view=patch > > > > http://svn.apache.org/viewvc/mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialSessionImpl.java?r1=824254&r2=824255&pathrev=824255&view=patch > > > > I think it'll make the job. > > > > Julien > > > > Le Fri, 9 Oct 2009 15:57:14 -0500, > > "Bob Gage" <[email protected]> a écrit : > > > > > >> > >> Course I always think of the obvious right after hitting send.... > >> > >> Is there anything I should be doing to control the flow once I've > >> declared hardware flow control (C++ code sets DTR & RTS after > >> open), or does Mina handle that for me?? Thanks again!! > >> boB > >> > >> ________________________________ > >> > >> From: Bob Gage [mailto:[email protected]] > >> Sent: Fri 10/9/2009 3:36 PM > >> To: [email protected] > >> Subject: RE: RTS/CTS Serial flow control > >> > >> > >> > >> Thanks for the quick turn around!!! > >> > >> I've updated & rebuilt my mina package, set my project to look for > >> M7-SNAPSHOT, rebuilt my app, and am about to test.... :-) > >> > >> Crossing fingers ..... NOW :-) > >> boB > >> > >> > >> > >> ________________________________ > >> > >> From: Julien Vermillard [mailto:[email protected]] > >> Sent: Fri 10/9/2009 11:55 AM > >> To: [email protected] > >> Subject: Re: RTS/CTS Serial flow control > >> > >> > >> > >> Le Fri, 9 Oct 2009 10:30:11 -0500, > >> "Bob Gage" <[email protected]> a écrit : > >> > >> > >>> Its in as DIRMINA-740. > >>> > >>> If you could pass a patch on to me, I'd be glad to try it out! > >>> I'm already using a modified M6 with a previous fix, so throwing > >>> another patch in is not a problem. :-) Thanks again!! > >>> boB > >>> > >>> > >> Fix commited > >> Here the patch : > >> > >> http://svn.apache.org/viewvc/mina/trunk/transport-serial/src/main/java/org/apache/mina/transport/serial/SerialAddress.java?p2=%2Fmina%2Ftrunk%2Ftransport-serial%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fmina%2Ftransport%2Fserial%2FSerialAddress.java&p1=%2Fmina%2Ftrunk%2Ftransport-serial%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fmina%2Ftransport%2Fserial%2FSerialAddress.java&r1=823596&r2=823595&pathrev=823596&view=patch > >> > >> > >> Try to use : FlowControl.RTSCTS_IN_OUT > >> > >> > >> > >>> ________________________________ > >>> > >>> From: Julien Vermillard [mailto:[email protected]] > >>> Sent: Fri 10/9/2009 11:13 AM > >>> To: [email protected] > >>> Subject: Re: RTS/CTS Serial flow control > >>> > >>> > >>> > >>> Le Fri, 9 Oct 2009 17:09:05 +0200, > >>> Julien Vermillard <[email protected]> a écrit : > >>> > >>> > >>>> Le Fri, 9 Oct 2009 09:46:10 -0500, > >>>> "Bob Gage" <[email protected]> a écrit : > >>>> > >>>> > >>>>> Is serial hardware flow control properly working in Mina 2.0?? > >>>>> > >>>>> I have an application that communicates with a variety of > >>>>> similar serial devices using the same collection of generic > >>>>> objects over Mina. These are working very well for the most > >>>>> part -- however, one specific device requires hardware flow > >>>>> control, and that device has yet to produce a single byte of > >>>>> input data. My application is replacing an old C++ > >>>>> application. That application has been used to confirm the > >>>>> operation of the serial hardware and external device. IOW, I > >>>>> can switch to the old C++ application and the device is there; > >>>>> switch back to the Mina-based Java app and it's silent again. > >>>>> > >>>>> Is there anything my code (as user of the Mina libraries) needs > >>>>> to do to support flow control other than using the > >>>>> FlowControl.RTSCTS_OUT parameter in the SerialAddress > >>>>> constructor? > >>>>> > >>>>> Thanks in advance!! > >>>>> boB Gage > >>>>> > >>>>> > >>>> Hi bob, > >>>> > >>>> I personally never tried mina serial transport with flow control > >>>> (perhaps someone did ?). I'm going to take a look at the code for > >>>> see if everything is ok. > >>>> > >>>> Julien > >>>> > >>> Look like I totally misunderstood rxtx API, it's using bit mask > >>> and mina serial transport use enumeration.. > >>> > >>> Can you create a JIRA issue ? I'll try to fix it. > >>> > >>> > >>> Thanks for the report, > >>> Julien > >>> > >>> > >>> > >> > >> > >> >
signature.asc
Description: PGP signature
