Le 22 mars 2012 19:49, "David R Robison" <[email protected]>
a écrit :
>
> Yes, but I'm seeing a OutOfMemory exception when calling this routine.
again, the OOM is not due to the Integer.MAX_VALUE, but to the size of your
buffer. Also you can call the method with an extra parameter to limit the
size of what is being dumped. Just use it.
> Any thoughts about reducing that to Short.MAX_VALUE? I assume that this
> dump is for debug purposes only. Thanks, David
>
> On 3/22/2012 2:29 PM, Emmanuel Lécharny wrote:
> > Le 3/22/12 6:51 PM, David R Robison a écrit :
> >> The getHexDump function in AbstractIoBuffer is
> >>
> >> /**
> >> * {@inheritDoc}
> >> */
> >> @Override
> >> public String getHexDump() {
> >> return this.getHexDump(Integer.MAX_VALUE);
> >> }
> >>
> >> I am wondering if maybe Integer.MAX_VALUE should be changed to
> >> Short.MAX_VALUE to save on heap space. Any thoughts? David
> >
> > This is just a configuration parameter. It will be used only if the
> > ByteBuffer to dump is bigger than Integer.MAX_VALUE, something that is
> > *very* unlikely to happen...
> >
> >
>
> --
>
> David R Robison
> Open Roads Consulting, Inc.
> 103 Watson Road, Chesapeake, VA 23320
> phone: (757) 546-3401
> e-mail: [email protected]
> web: http://openroadsconsulting.com
> blog: http://therobe.blogspot.com
> book:
http://www.xulonpress.com/bookstore/bookdetail.php?PB_ISBN=9781597816526
>
>
>
> This email communication (including any attachments) may contain
confidential and/or privileged material intended solely for the individual
or entity to which it is addressed.
> If you are not the intended recipient, please delete this email
immediately.
>
