David, The `buf.mark()` and `buf.reset()` calls are dangerous when used in conjunction with a dynamic call stack and are being removed from the MINA Filter system to improve compatibility with the code you write.
1> Some things aren't being back-ported to 2.0.X, the SSL improvements are one. 2> What call? the mark() was removed, so it is not needed. 3> Shouldn't be necessary because you shouldn't have to change any of your code. Did removal of this mark() break your code? On Fri, May 3, 2019 at 6:29 PM David Trott <m...@davidtrott.com> wrote: > Hey, > > I am working on an IoFilter similar in location/function to the SslFilter > (but implementing a different protocol). I noted there was a delta between > 2.0 and 2.1 code in the SslFilter. > > Specifically commit 2d08d530961597b9f21dff861725f08e73fb9291 > Has removed the call to buf.mark(); // Approx Line 654 > > In my filter (compiled against 2.0) I also need the same buf.mark() call as > the SslFilter uses. > > Could I ask the following questions: > 1.> Why does the 2.0 code base need this call? > 2.> Is this call needed in the 2.1 code base? > 3.> Would it be possible to update the (2.1-vs-2.0) migration web page to > include a note about this change? > > > Thanks, > David >
