Someone might use it in a facet to determine whether that facet is a branch
or a leaf if they had a layout with facets that could be either a branch or
a leaf.

<f:facet name="multi">
    <h:graphicImage value="t.leaf ? 'folder.gif' : 'doc.gif'>
</f:facet>

If anything the tree component should be using isLeaf to determine whether
or not its a leaf.  What if I want a leaf that has children but I don't want
to display it as a branch because I have a different viewer for those
special types of children. I might want to know the child count and get the
children but I want the tree to display a leaf node.

I don't see that the type of facet determines what type of icon to use. The
type of facet just determines where the tree will lay the node out. What's
in the node (facet) is entirely up to the user of the component.




----- Original Message ----- 
From: "Sean Schofield" <[EMAIL PROTECTED]>
To: "MyFaces Discussion" <[email protected]>
Sent: Wednesday, April 27, 2005 12:04 PM
Subject: [tree2] Who is using the isLeaf method? Should we deprecate this
method?


Sureshbabu pointed out something interesting in an earlier post.  The
TreeBacker class has the boolean values for leaf reversed.  So all of
the branch nodes have setLeaf(true) and visa versa.

I will fix this in CVS now, but there is another interesting point
here.  It doesn't matter to any of the simple examples!  This is
because the getType method is used to determine the facet (and hence
what type of icon to use).  The navigation icons (the plus/minus
icons) are determined by the child count.

IMO the getChildCount method and the getType methods could cover
pretty much every scenario that you would need isLeaf for.  I have
opened a JIRA issue (MYFACES-215) to suggest we deprecate the is Leaf
method (and eventually eliminate it.)  Please add comments there if
you have feelings on this one way or another.

sean

Reply via email to