On 8/7/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Thanks Matthias, > > any comment on the actual bug? > Also was the ValueBindingValueExpression introduced for 1.2 (and immediately > marked deprecated) or was it already removed/refactored on trunk?
Trunk is JSF 1.1. Ergo, it doesn't exist. We're using a branch for 1.2 support. ValueBindingValueExpression is an adapter class that wraps a ValueBinding, and turns it into a ValueExpression. It's deprecated because ValueBindings are deprecated - ergo, avoid using it. We can't pass the ELContext into ValueBinding, because ValueBinding doesn't take ELContext, it takes FacesContext. (We could be retrieving the FacesContext off of the ELContext, but it'd be the same FacesContext instance.) I've no idea what change you're recommending in the code. My hunch is the major issue is that something is creating a ValueBinding instead of a ValueExpression. Could you find out what bit of code is creating a ValueBinding, and why? -- Adam > Ignoring the ELContext that gets passed in to each method is definitly a bug. > > Cheers > Stephen > > > Hi, > > the branch for 1.2.x is designed for JSF 1.2 > (that's the one that contains the ValueBindingValueExpression) > > the trunk is designed for JSF 1.1, that's the one that contains no > ValueBindingValueExpression > > However, the sources are deployed to a maven2 repo. > The URL for API sources JAR: > http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/myfaces/trinidad/trinid > ad-api/1.2.1/trinidad-api-1.2.1-sources.jar > > The URL for IMPL sources JAR: > http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/myfaces/trinidad/trinid > ad-impl/1.2.1/trinidad-impl-1.2.1-sources.jar > > I'll add some sentences that make it more clear, on our 1.0.x (trunk) > and 1.2.x series. > > Greetings, > Matthias > > On 8/7/07, Stephen Friedrich <[EMAIL PROTECTED]> wrote: > > Can somebody with more Trinidad experience please take a look at > > Validators not working for ValueBindings from Trinidad: > http://jira.jboss.com/jira/browse/JBSEAM-1667 > > It was reported on the JBoss Seam Jira, but seems to be a Trinidad problem. > > I see that ValueBindingValueExpression is deprecated, but you don't really > make it easy for a newcomer > > to get aquainted with Trinidad sources. > > I don't really know where the sources for 1.2.x are located in svn. The > project page just does not tell. > > There is a branch for 1.2.1 and it really contains a faulty > ValueBindingValueExpression: > > It simply ignores the ELContext that gets passed in (by Seam), so in effect > bypassing Seam. > > In trunk there is no ValueBindingValueExpression (anymore?). > > There should be nightly builds (according to the project page) but when I > follow the link they are nowhere > > in sight. > > > > Anybody? > > > > > -- > Matthias Wessendorf > > further stuff: > blog: http://matthiaswessendorf.wordpress.com/ > mail: matzew-at-apache-dot-org >
