On 10/17/07, max.starets <[EMAIL PROTECTED]> wrote:
>
> Thanks, Adam.
>
> I like your suggestion. The only exception I see is that we would still
> establish currency for selection events. Agreed?

Wouldn't that still mean that if you launch a dialog during a selection
event, the return will fail?.  Or that PPR'ing a facet of the table in response
to a selection event will likely fail?

I'm wondering if we want something much uglier here:  a way to
still establish currency (and do it for all events), but without
mucking with client IDs.

-- Adam


>
> I will submit a new patch for review. Sorry for introducing the bug in a
> first place.
>
> Max
>
>
>
> Adam Winer wrote:
> >
> >
> > The fix, I think, is to not set the currency, but instead merely
> > set up the EL state as if currency were set, e.g. going from
> >   - set row key to first selected row
> >   - process the event
> >   - restore row key
> >
> > ... to the more verbose:
> >
> >   - get original values "var" and "varStatus" off the request map
> >   - set row key to first selected row
> >   - grab new "var" and "varStatus" off the request map
> >   - restore row key
> >   - set new "var" and "varStatus" onto the request map
> >   - process the event
> >   - restore "var" and "varStatus" to original values
> >
> > For now, you can work around this (significant) bug by
> > moving the panelButtonBar to after the table, and
> > out of the "footer".  But we should roll a 1.0.4 fairly
> > soon to fix this regression, and any others if they get
> > found soon.
> >
> >
> >
>
> --
> View this message in context: 
> http://www.nabble.com/-Trinidad-1.0.3--returnListener-is-broken-tf4594019.html#a13254310
> Sent from the MyFaces - Users mailing list archive at Nabble.com.
>
>

Reply via email to