Hi Martin,
Martin Marinschek wrote:
Hi ole,
what form are you using? h:form or s:form?
I'm using the h:form.
If you are using h:form,
then you'll be working against:
org/apache/myfaces/shared_impl/renderkit/html/HtmlFormRendererBase.java
In any case, you are right, they stem from the same source in:
org.apache.myfaces.shared.renderkit.html
Super.
- you should only need to change this, do a full maven build, and this
should take on your changes.
This is what I did initially (Might be valuable in case there are some build
issues):
svn co http://svn.apache.org/repos/asf/myfaces/shared/branches/3_0_0
myfaces-shared-3.0.0
Then made the change, deleted myfaces from the repository, and rebuilt. My
assumption was that these changes would replace the dependencies needed by the
webapp dependencies (And it did seem to work because maven only downloaded
non-shared artifact):
<dependency>
<groupId>org.apache.myfaces.core</groupId>
<artifactId>myfaces-api</artifactId>
<version>1.2.0</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.myfaces.core</groupId>
<artifactId>myfaces-impl</artifactId>
<version>1.2.0</version>
<scope>runtime</scope>
</dependency>
However the the webapp worked the same way as before, even with everything
commented out in the renderer.
The problem might however be that the
pom.xml of MyFaces impl is referring to an old version of shared, so
you might need to upgrade this to the snapshot version so that you
actually see your changes when you do the build.
I did check the dependency management of the parent project in
myfaces_core_1.2.0 and it had this in it:
<dependency>
<groupId>org.apache.myfaces.shared</groupId>
<artifactId>myfaces-shared-impl</artifactId>
<version>3.0.0</version>
</dependency>
But maybe that was updated post sending the release artifacts to the
repository? In any case I'll try a snapshot build, as you are recommending.
Is there a svn co ... that checks out an entire build with everything in it. I
tried looking at the source checkout page within the myfaces site, but that
command only checks out the website ... (Incidentally should I file a JIRA to
have this updated / looked at?) and when I browse around in subclipse I see
there is core/trunk and core/trunk1.2.x and correspondingly shared/trunk and
shared/trunk3.0.x.
I'm assuming I should check out 1.2.x 3.0.x and rebuild these?
Thanks again for all your help,
- Ole
