2009/8/9 Ryusuke Konishi <[email protected]> > Hi! > On Sun, 09 Aug 2009 19:13:10 +0800, Zhang Qiang wrote: > > nilfs2: In procedure 'nilfs_get_sb()', when a nilfs filesysttem is > mounted for the first time, local variable 'nilfs->ns_last_cno' is used > before loading the latest checkpoint number from disk (in > 'nilfs_fill_super'). 'nilfs->ns_last_cno' is assigned to 'sd.cno', but > 'sd.cno' has never been used in the procedure. > > > > Signed-off-by: Zhang Qiang <[email protected]> > > > > --- > > fs/nilfs2/super.c | 4 ---- > > 1 files changed, 0 insertions(+), 4 deletions(-) > > > > diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c > > index 8e2ec43..d8bfcfd 100644 > > --- a/fs/nilfs2/super.c > > +++ b/fs/nilfs2/super.c > > @@ -1125,10 +1125,6 @@ nilfs_get_sb(struct file_system_type *fs_type, int > flags, > > */ > > sd.sbi = nilfs_find_sbinfo(nilfs, !(flags & MS_RDONLY), sd.cno); > > > > - if (!sd.cno) > > - /* trying to get the latest checkpoint. */ > > - sd.cno = nilfs_last_cno(nilfs); > > - > > /* > > * Get super block instance holding the nilfs_sb_info struct. > > * A new instance is allocated if no existing mount is present or > > -- > > 1.6.0.6 > > Right. The substitution became obsolete after a change merged in > 2.6.31-rc1. > > Applied. Thank you. > > Ryusuke Konishi >
Thanks a lot :-) -Regards -Qiang
_______________________________________________ users mailing list [email protected] https://www.nilfs.org/mailman/listinfo/users
