Hi! On Fri, 27 Nov 2009 15:21:06 +0100, David Smid <da...@unity-linux.org> wrote: > Hi, > > I have two nilfs2 partitions and want to set different protection period for > each of them. I know nilfs_cleanerd has an option -p which allows to override > the protection period but using it would require to mount both partitions and > launch their cleaner daemons manually or within a script. > Since I want to use fstab I had to implement this option as a mount.nilfs2 > extra > option. > > Not much was done to the kernel module: it just had to accept 'pp=' as a valid > mount option. > mount.nilfs2 was modified to parse this option and its value and to pass it to > nilfs_cleanerd command line. > > See the patches. > > > Regards, > > David Smid
Thank you for the patches. I understood your intention. One comment. I don't like the dummy option is added to the kernel code because protection_period is entirely independent with it. Can you modify the patch so that mount.nilfs2 gets out the pp option from the string passed to the mount system call? A ready-made function, change_opt() would be available for that purpose. (only from extra_opts; mtab should include it to keep the value for cleanerd_ctl, of course) And, please inline patches in the mail; this makes it easy to comment on them. Thanks, Ryusuke Konishi _______________________________________________ users mailing list users@nilfs.org https://www.nilfs.org/mailman/listinfo/users
