Hi Sandro, Dave Neary's comment is good. Here is a new patch:
*** a/ovirt-release.spec 2014-02-21 10:10:00.000000000 -0500 --- b/ovirt-release.spec 2014-02-21 13:01:35.856636466 -0500 *************** *** 69,75 ****#Fedora is good for both Fedora and Generic (and probably other based on Fedora)
#Handling EL exception only (for now)
! if grep -qFi 'CentOS' /etc/system-release; then
! DIST=EL
! elif grep -qFi 'Red Hat' /etc/system-release; then
DIST=EL
fi
--- 69,73 ----
#Fedora is good for both Fedora and Generic (and probably other based
on Fedora)
#Handling EL exception only (for now)
! if rpm --eval "%dist" | grep -qFi 'el'; then
DIST=EL
fi
Might be faster for you to submit cause I'm not familiar with gerrit,
but I can login with my Fedora FAS account.
Cheers, Jimmy On 2/21/14, 8:17 AM, Sandro Bonazzola wrote:
Il 21/02/2014 16:25, Jimmy Dorff ha scritto:On 2/21/14, 2:31 AM, Sandro Bonazzola wrote:Il 21/02/2014 07:34, Meital Bourvine ha scritto:Hi Jimmy, As far as I know, scientific linux isn't supported by ovirt.IIUC it's based on CentOS / RHEL so it may work. Let us know if you've issues :-)But you can always try submitting a patch ;)SL works fine with ovirt. If you want to "support it", here is a patch.http://gerrit.ovirt.org/24869 If you've an account on gerrit you can review / verify it.*** a/ovirt-release.spec 2014-02-21 10:10:00.000000000 -0500 --- b/ovirt-release.spec 2014-02-21 10:10:55.000000000 -0500 *************** *** 73,76 **** --- 73,78 ---- elif grep -qFi 'Red Hat' /etc/system-release; then DIST=EL + elif grep -qFi 'Scientific Linux' /etc/system-release; then + DIST=EL fi If you don't support Scientific Linux, then I would recommend not defaulting the DIST to Fedora and instead searching for the specific supported releases and error out otherwise. Future-wise, Scientific Linux *may* become a "CentOS variant" in Red Hat's CentOS. Cheers, Jimmy
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users
