On 03/09/2017 11:11 AM, Gianluca Cecchi wrote: > On Thu, Mar 9, 2017 at 10:58 AM, Juan Hernández <jhern...@redhat.com > <mailto:jhern...@redhat.com>> wrote: > > > > Very good point Gialuca, you are right, the 'persist_memorystate' flag > is 'true' by default, and that makes the pause longer. Would you be so > kind to add it to the 'vm_backup.py' example that is part of version 4 > of the SDK? > > > > https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/vm_backup.py#L143-L151 > > <https://github.com/oVirt/ovirt-engine-sdk/blob/master/sdk/examples/vm_backup.py#L143-L151> > > (Note that that Gibhub is just a mirror, the change needs to be submited > using gerrit.ovirt.org <http://gerrit.ovirt.org>). > > > > I already verified (on a 4.1 infra) that changing vm_backup.py > downloaded yesterday from master this way (apart connection paramters): > > $ diff vm_backup.py vm_backup.py.orig > 150d149 > < persist_memorystate=False, > > I get the backup result and snapshot is correctly without memory saved > (and no pause at VM side) > > In engine events I get: > > Mar 9, 2017 10:50:39 AM Snapshot > 'Oracle7-backup-c6bf637e-cdeb-4923-a39f-55a14d7bad7b' deletion for VM > 'Oracle7' has been completed. > Mar 9, 2017 10:49:48 AM Backup of virtual machine 'Oracle7' using > snapshot 'Oracle7-backup-c6bf637e-cdeb-4923-a39f-55a14d7bad7b' is completed. > Mar 9, 2017 10:49:48 AM Snapshot > 'Oracle7-backup-c6bf637e-cdeb-4923-a39f-55a14d7bad7b' deletion for VM > 'Oracle7' was initiated by admin@internal-authz. > Mar 9, 2017 10:49:47 AM Disk Oracle7_Disk1 was successfully detached > from VM c7testovn1 by admin@internal-authz. > Mar 9, 2017 10:49:45 AM Disk Oracle7_Disk1 was successfully attached to > VM c7testovn1 by admin@internal-authz. > Mar 9, 2017 10:49:41 AM Snapshot > 'Oracle7-backup-c6bf637e-cdeb-4923-a39f-55a14d7bad7b' creation for VM > 'Oracle7' has been completed. > Mar 9, 2017 10:49:29 AM Snapshot > 'Oracle7-backup-c6bf637e-cdeb-4923-a39f-55a14d7bad7b' creation for VM > 'Oracle7' was initiated by admin@internal-authz. > Mar 9, 2017 10:49:28 AM Backup of virtual machine 'Oracle7' using > snapshot 'Oracle7-backup-c6bf637e-cdeb-4923-a39f-55a14d7bad7b' is starting. > > > I have almost no experience in gerrit/github, unfortunately... only a > beginner experience in svn ... ;-) > If you give me some pointers I can try to apply what you asked... > > Gianluca
I see that you already have a gerrit.ovirt.org, so it shouldn't be difficult. The initial setup should be like this: $ git config --global user.name youruser $ git config --global user.email your@email $ git clone ssh://youru...@gerrit.ovirt.org:29418/ovirt-engine-sdk $ gitdir=$(git rev-parse --git-dir); scp -p -P 29418 youru...@gerrit.ovirt.org:hooks/commit-msg ${gitdir}/hooks/ Then, to submit the patch: $ cd ovirt-engine-sdk $ Edit the vm_backup.py file, and make your changes. $ git commit -a -s $ git push origin HEAD:refs/for/master _______________________________________________ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users