Am 28.02.2015 um 17:58 schrieb Tilman Hausherr:
Am 28.02.2015 um 17:49 schrieb Maruan Sahyoun:
>>
>>- why change only one of the members of that cosobjectkey class to int?
>>According to the spec, both are integers. Maybe there's a good reason, but
I'd
>>like to know.
>ASFAIK there is no good reason not to change both to int.
as the offset is a 10 digit number is that really covered being an int?
I would have waited for his explanation... and now I understand what he may have
thought - consider this change you did:
- new COSObjectKey(-fileOffset, 0));
+ new COSObjectKey((int)-fileOffset, 0));
the first paramater has a double usage within PDFBox, if negative it is an
offset in an object stream. Do we know that these are always smaller than
0x7FFFFFFF ?
Yeah, you are right and I'm not happy with that change, too. Maybe I should have
add a comment. We should refactor that part too, I already have somethin in my
mind ....
BR
Andreas
Tilman
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
