Thanks. Dave P
On Sat, Nov 4, 2017 at 5:40 PM, Tilman Hausherr <[email protected]> wrote: > Done: > https://issues.apache.org/jira/browse/PDFBOX-3991 > > Tilman > > > Am 30.10.2017 um 21:21 schrieb David Patterson: > >> Thanks. >> >> Dave P >> >> On Mon, Oct 30, 2017 at 3:48 PM, Tilman Hausherr <[email protected]> >> wrote: >> >> Am 30.10.2017 um 19:48 schrieb David Patterson: >>> >>> I was crawling through this class over the weekend and saw something that >>>> seemed strange. I'm not sure if it is a bug or not. >>>> >>>> There is a version of the setStrokingColor (line 1112 in the 2.0.7 >>>> codebase) with four parameters, all float: c, m, y, k. The values are >>>> used >>>> for calls to writeOperand without any conversion. >>>> >>>> There is a version of the setNonStrokingColor (line 1302 in the 2.0.7 >>>> codebase) with four parameters, all double: c, m, y, k. The values are >>>> used >>>> for calls to writeOperand, but each is coerced to be a float. >>>> >>>> Should the parameter signature on the setNonStrokingColor be changed to >>>> require floats? >>>> >>>> Yes. Good find! I'll change it later this week. >>> >>> Tilman >>> >>> >>> I am not using these calls, but saw them and they struck me as odd. >>>> >>>> Dave Patterson >>>> >>>> >>>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
