Here’s the trick (I also didn’t know): 
https://stackoverflow.com/questions/6188591/download-github-pull-request-as-unified-diff

So here’s the diff: https://github.com/apache/pdfbox/pull/40.diff
and the patch: https://github.com/apache/pdfbox/pull/40.patch

I’ll also comment in the JIRA issue…

Andreas


On 2017-12-07, at 17:27, Tilman Hausherr 
<[email protected]<mailto:[email protected]>> wrote:

I forgot about that one because I was busy last week... but I had targeted it 
to 2.0.9 so we would notice it when deciding about the release. I had a look at 
the change, it is probably OK, could you please attach it as a diff / patch 
file and then close the PR? The github repository is read only. I don't know 
how to create a diff from there (I assume it's possible, I haven't tried to 
find out)

Tilman


Am 07.12.2017 um 14:30 schrieb Andreas Pehnack:
Hello,

is there something more I can do to get 
https://issues.apache.org/jira/browse/PDFBOX-4025 resolved than creating a pull 
request?

Thank you for any feedback… :)
Andreas




---------------------------------------------------------------------
To unsubscribe, e-mail: 
[email protected]<mailto:[email protected]>
For additional commands, e-mail: 
[email protected]<mailto:[email protected]>


Reply via email to