I had a look. I'm not really good at comparing colors and decide which
is better (but I'm not color blind). I did find two that are visibly
improved:
- bugzilla867751.pdf page 1 better, the "color edge" is gone (can be
seen near "type 5751")
- PDFBOX-4121-CMYK-slow-p1.pdf the "break" in the shading is now
correctly near the neck of the worker, no longer near his back. The
black background looks more accurate.
Thus +1 from me. But I think this should be in 3.0 only, so that people
who run visual comparison tests don't get too much work in 2.0. (They
can still do it with the method I explained)
Tilman
On 12.01.2023 08:42, Tilman Hausherr wrote:
On 12.01.2023 08:00, Andreas Lehmkuehler wrote:
Am 11.01.23 um 02:20 schrieb Etienne Gautier:
Hey, I noticed that the images were still not going through email
(not sure
Due to some limitation to the ML
what's happening), so instead I created a PR that has all the
screenshots
attached in the description, and the proposed change.
Please see the PR here <https://github.com/apache/pdfbox/pull/150>
and let
me know if you are interested in merging this change.
Looks like an improvement. The CC0 license is compatible see [1]
I'm ok with replacing the ICC profile with the proposed one.
@Tilman is there any chance to run a test to see if there are any
negative side effects?
This will have to wait until some time next week, maybe earlier, due
to lack of time this week. I ran the tests and there are 700
differences. I would have to look at many of them to see that it
doesn't get worse.
I don't mind that this gets replaced anyway for now.
Tilman
Andreas
[1]
https://www.apache.org/legal/resolved#handling-public-domain-licensed-works
All the best, Etienne.
On Wed, Jan 11, 2023 at 11:13 AM Etienne Gautier <etie...@canva.com>
wrote:
Hello and thanks for getting back quickly,
Hopefully you can see the screenshots now attached (instead of
embedded)
to this email.
Thanks for suggesting this workaround, that will solve our problem.
Please have a look at the screenshots and consider using this
<https://github.com/saucecontrol/Compact-ICC-Profiles#cmyk> ICC
profile
(under Creative Commons CC0). I think that the visual improvement
is pretty
clear, and it would be valuable for other PDFBox users who did not
override
the deviceCMYK profile (including those who cannot use
USWebCoatedSWOP for
license reasons).
Cheers,
Etienne
On Wed, Jan 11, 2023 at 5:44 AM Tilman Hausherr
<thaush...@t-online.de>
wrote:
On 10.01.2023 03:57, Etienne Gautier wrote:
WDYT about changing the deviceCMYK color profile? Or making it
configurable at runtime?
Hi, your images didn't get through. You can use these profiles
like this:
//
https://www.adobe.com/support/downloads/iccprofiles/iccprofiles_win.html
PDDeviceCMYK.INSTANCE = new PDDeviceCMYK()
{
@Override
protected ICC_Profile getICCProfile() throws
IOException
{
return
ICC_Profile.getInstance("USWebCoatedSWOP.icc");
}
};
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: users-h...@pdfbox.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: users-h...@pdfbox.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: users-h...@pdfbox.apache.org
