Hi Brian, Thank you for your comments.
Here are some replies to your comments. > Comment 1 We were thinking that "subscriptions" should be a first-class citizen in the CLI. so we moved the subscription related commands to a separate command group. We can consider supporting the old style commands as well if needed. > Comment 2 I think we can improve the CLI by adding an option `-o` or `--output`. Let user choose the way to dump the results, either PLAIN, TABLE, or JSON. Does this approach work for you? > Comment 3 Yong sent out a pull request to fix this issue. Thank you for reporting it. - Sijie On Mon, Oct 28, 2019 at 8:16 PM Brian Candler <[email protected]> wrote: > On 28/10/2019 11:49, Brian Candler wrote: > > > > Many, many thanks for this - I will be compiling it shortly. > > I see you already made a binary release of pulsarctl, so even better :-) > > Comment 1: I find the CLI doesn't follow the Java pulsar-admin CLI. > > # pulsar-admin version > $ apache-pulsar-2.4.1/bin/pulsar-admin topics subscriptions > persistent://public/default/my-topic > my-subscription > first-subscription > > # pulsarctl version > $ ./pulsarctl subscriptions list persistent://public/default/my-topic > +--------------------+ > | SUBSCRIPTIONS | > +--------------------+ > | my-subscription | > | first-subscription | > +--------------------+ > > I now have a new set of commands to learn - although maybe I'll just > forget the Java ones going forward. > > Comment 2: I can't see a way to disable the table formatting, e.g. to > get just the raw list of subscriptions in the example above. This would > be useful for simple scripting. An option to return all tables as csv > or tsv would be nice. (Ditto for clusters list, brokers list) > > JSON would be another option, especially since some commands already > give JSON output (e.g. topic lookup, topic stats) > > Comment 3: There is a newline missing after the command output here: > > ubuntu@pulsar:~$ ./pulsarctl topic compact-status public/default/my-topic > Compacting the topic persistent://public/default/my-topic is not > runningubuntu@pulsar:~$ > > But this is a great start, thanks again! > > Regards, > > Brian. > >
