On 14 February 2012 15:27, Gordon Sim <[email protected]> wrote: > On 02/14/2012 03:06 PM, Gordon Sim wrote: >> >> The declare sent has the passive flag set to true. >> >> I would argue that in the spirit of that flag, it should be perfectly >> valid not to specify the type since we are simply asserting that it >> exists, not trying to create it if it does not. I couldn't find anything >> one way or the other in the specification however. (Attached patch to >> relax the check in the java broker along these lines for consideration). > > > Doh! Patch corrected, I am suitably mortified at my stupid mistake... > > Once I tested against the right broker I discovered that I wasn't even > fixing the correct codepath. The corrected patch makes the change to bothe > 0-8/0-9 and 0-10, but obviously the 0-10 case is the relevant one in this > case. >
Woops, I had missed the passive flag:P The patch seems reasonable, I'll apply it when I'm home later. Robbie --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
