On 1 November 2012 08:20, Gordon Sim <gordon.r....@gmail.com> wrote: > On 10/31/2012 11:09 PM, Robbie Gemmell wrote: > >> The log line below seems to suggest it is the same issue Jeremy was >> seeing, >> that the client is not selecting a SASL mechanism during connection and >> the >> broker is ultimately killing it as a result. >> > > Agreed. It seems a little odd that the conversation gets as far as it does > though. The mechanism is left unspecified on the connection-start-ok, the > broker responds with connection-tune and the handshake gets as far as the > broker sending a connection-open-ok... does the java broker only do > authentication after it has sent the connection-open-ok? > > You are right, it shouldnt have got that far, good catch. (Yes, I stopped reading the log once I saw the missing mechanisms).
Authentication is performed at connection-start-ok, but looking into the process there is a bit of crufty old code that long predating the brokers use of it for 0-10 support that is causing it to respond incorrectly in this situation, sending a connection-tune it shouldnt have and ultimately allowing it to get as far as then causing the NPE because the mechanism wasnt set. Instead it should be responding by immediately killing the connection deliberately rather than just as a side effect.So thats definitely a bit of broker side fixup required too it seems. > > Alex mentioned in a discussion >> about this that its actually NPEing on the broker side in this situation, >> so we can/should make the broker handle that with a little more grace to >> make the problem more, although it is really the client at fault. >> > > Agreed. The client should pick one of the offered mechanisms or fail with > a message if it doesn't support any of them. I've created a JIRA: > https://issues.apache.org/**jira/browse/QPID-4407<https://issues.apache.org/jira/browse/QPID-4407> > . > > > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > users-unsubscribe@qpid.apache.**org<users-unsubscr...@qpid.apache.org> > For additional commands, e-mail: users-h...@qpid.apache.org > >
