This is now approved.
On Wed, Sep 3, 2014 at 11:40 PM, Andrew Stitcher <[email protected]> wrote: > On Wed, 2014-09-03 at 15:58 -0700, [email protected] > wrote: > > Hello Andrew, > > > > Actually, you also need to modify the declaration for argv so that it > doesn't have the args.size() as its parameter. Since you modified it to use > push_back, it will actually append to the end at index args.size() instead > of at index 0. As it stands, the first args.size() elements would all be > NULL. > > Thanks for checking - you are correct (for some reason, I was under the > impression that this constructor only reserves the specified amount of > space). > > Oddly the unit_tests still pass, which is why I didn't spot it - I guess > the options parser just ignores empty command line args. > > I'll fix it straight away. > > Andrew > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
