On Thu, 2015-01-29 at 10:05 -0500, Justin Ross wrote: > The Proton C code has a lot of redundant includes. That is, headers often > directly include items they already have transitively. This makes some of > the dependency graphs in our api doc less attractive and less helpful: > > > http://qpid.apache.org/releases/qpid-proton-0.8/protocol-engine/c/api/connection_8h.html > > http://qpid.apache.org/releases/qpid-proton-0.8/protocol-engine/c/api/message_8h.html > > http://qpid.apache.org/releases/qpid-proton-0.8/protocol-engine/c/api/messenger_8h.html > (this is a really good one) > > http://qpid.apache.org/releases/qpid-proton-0.8/protocol-engine/c/api/transport_8h.html > > If there's no technical objection, I'd like to produce a patch to remove > the unnecessary includes. Are there any platform or compiler issues I > should be aware of?
+1 for redundant (already transitively included) headers. Just beware if you get more enthusiastic: removing un-necessary (as opposed to redundant) includes is source incompatible for .c files that rely on getting the included .h indirectly. In C++ un-necessary includes can be a surprisingly large chunk of the build time, but in C on a project of proton's size this probably isn't important. Cheers, Alan. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
