+1 On 15 April 2016 at 15:00, Robbie Gemmell <[email protected]> wrote:
> +1 > > On 15 April 2016 at 12:28, Robbie Gemmell <[email protected]> > wrote: > > Given the shorter name is consistent with previous 6.0.x releases, is > > what the contents are actually named, and is just nicer, I would again > > suggest renaming it. It might be good to update the build to create it > > with that name, e.g having a dedicated module do it, or just > > tweak/script the process of pulling it down from Nexus after creation > > to do it. > > > > The checksums+sigs wouldnt actually need regenerated currently, just > > renamed, as the sig doesn't consider the name and the checksums > > generated by Nexus don't contain the name. I think Lorenz pointed out > > previously that it would be good if the checksums in the dist repo did > > actually contain the file name, as otherwise they don't work with the > > handy -c check flag from tools. > > > > As Alex said, Keith's key needs added to the KEYS file in the dist > > repo (and its source in our repo). It is however in > > https://people.apache.org/keys/committer/kwall.asc and > > https://people.apache.org/keys/group/qpid.asc so I was able to verify > > the sig files. > > > > I tested things out as follows: > > - Verified all the sigs > > - Verified the source release checksums (updated with filename to > > allow using tool -c flags) > > - Used RAT to check the licence (see note below). > > - Ran the source build > > - Extracted the broker binary, started it, created a queue with the web > console. > > - Ran the Qpid JMS 0.9.0 HelloWorld example against the broker. > > > > When doing "mvn apache-rat:check" within the src archvie it fails due > > to the DEPENDENCIES file maven auto generated. The check passes after > > deleting that file. Not a blocker, but would be good to fix for future > > (perhaps just excluding the file, given it doesnt contain any useful > > dep info as the build pom has no deps itself). > > > > For now I'm +0.9, I'd be +1 with a rename. > > > > Robbie > > > > On 15 April 2016 at 11:19, Oleksandr Rudyy <[email protected]> wrote: > >> I made the following checks: > >> 1) Verified pgp signatures against public keys in > >> http://www.apache.org/dist/qpid/KEYS. Keith's signature is not there > >> and should be appended manually. > >> 2) Source bundle is named qpid-java-build-6.0.2.tar.gz but the site > >> generating script(s) expect(s) it to be named qpid-java-6.0.2.tar.gz. > >> I am fine with naming it qpid-java-build-6.0.2.tar.gz but we should > >> change site scripts. Alternatively, bundle can be renamed manually and > >> signatures regenerated > >> 3) Started broker and briefly clicked through operations on Web > >> Management Console. Everything worked fine for me > >> 4) Compiled 6.0.2 artifacts from source bundle. Everything compiled > successfully > >> 5) Run Hello/Spout/Drain examples. > >> > >> The question is do we want to rename source bundle into > qpid-java-6.0.2.tar.gz? > >> > >> Kind Regards, > >> Alex > >> > >> On 13 April 2016 at 14:04, Keith W <[email protected]> wrote: > >>> Hi all, > >>> > >>> A release candidate for the next release (6.0.2) of the Qpid Java > >>> Components has been created. > >>> > >>> The list of changes can be found in Jira: > >>> > >>> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20QPID%20AND%20fixVersion%20%3D%20qpid-java-6.0.2 > >>> > >>> Please test and vote accordingly. > >>> > >>> The source and binary archives can be grabbed from here: > >>> https://dist.apache.org/repos/dist/dev/qpid/java/6.0.2-rc1 > >>> > >>> Those files and the other maven artifacts are also staged for now at: > >>> https://repository.apache.org/content/repositories/orgapacheqpid-1071 > >>> > >>> Kind regards > >>> > >>> P.S. If you want to test it out using maven (e.g with the examples src, > >>> or your own things), you can temporarily add this to your poms to > access > >>> the staging repo: > >>> > >>> <repositories> > >>> <repository> > >>> <id>staging</id> > >>> <url> > https://repository.apache.org/content/repositories/orgapacheqpid-1071 > </url> > >>> </repository> > >>> </repositories> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: [email protected] > >>> For additional commands, e-mail: [email protected] > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
