Thank you Alan.
However, one thing which worries me is that compiling in RelWithDebInfo the test passed whereas it only failed in Debug mode. I know RelWithDebInfo activates optimizations but I don't believe fixing accessing a element of an empty vector is one of them. Do you know why this is the case? Should the test be updated to detect this issue in all build types? Regards, Adel Get Outlook for Android On Thu, Jun 2, 2016 at 11:59 AM -0700, "Alan Conway" <[email protected]> wrote: On Thu, 2016-06-02 at 14:18 -0400, Alan Conway wrote: > On Thu, 2016-06-02 at 14:07 -0400, Andrew Stitcher wrote: > > > > On Thu, 2016-06-02 at 10:29 -0700, Adel Boutros wrote: > > > > > > > > > Hello, > > > > > > While compiling the unit tests of Proton-c 0.12.2 on Visual > > > Studio > > > 2008 in > > > Debug mode, the cpp_scalar_test and cpp_value_test are failing > > > with > > > the > > > error: "C++ vector subscript out of range" > > > > [snip] > Agreed, it's the impl not the test that needs fixing. I'll add a fix > to > PROTON-1216: c++: proton::coerce<std::string>() should allow > conversion > from binary Grep finds a similar bug in several unrelated places, will fix all with a new JIRA to avoid confusion: https://issues.apache.org/jira/browse/PROTON-1225 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
