On Thu, 2017-01-05 at 08:35 +0000, Adel Boutros wrote: > Hello Andrew, > > > Issue reported and patch provided at head of master here: https://iss > ues.apache.org/jira/browse/PROTON-1382 > > 2 problems fixed: > > * Remove bit fields initialization to fix hanging tests on Solaris > > * Add missing include to fix incomplete type error on Solaris > (message.cpp, Error: Function "proton::link::error() const" with > incomplete return type "proton::error_condition", compiler cannot > generate virtual table in this situation..) > > > Could this be considered as a regression because Proton was compiling > on Solaris at 0.14.0?
Yep. I made the change because I was touching the struct anyway, in this particular case the use of bit-fields makes no difference so I'm fine with your fix. > Would it be possible to consider a 0.16.1 release in that case if > 0.17.0 is a bit far from being released? Sounds reasonable to me. > > Regards, > > Adel > > ________________________________ > From: Andrew Stitcher <[email protected]> > Sent: Wednesday, January 4, 2017 4:39:27 PM > To: [email protected] > Subject: Re: [Proton 0.16.0] [Solaris] Unit tests hanging when > destroying connection_driver > > On Wed, 2017-01-04 at 14:47 +0000, Adel Boutros wrote: > > I found the issue!! > > > > > > It is a Solaris compiler bug: > > > > Actually Solaris doesn't handle correctly bit fields in C. This is > > the case of the struct pn_collector_t (bool head_returned:1). > > We probably should just never be using bifields in this case - it is > pretty unusual in my experience (even if it seems like it would save > space in the struct). > > So I, for one, would definitely accept a patch to remove all uses of > bool bitfields. > > Andrew > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
