Thanks for the report Ganesh. I don't see that issue, and I doubt other committers have or I expect it would have been noted earlier, suggesting something different about your environment, which it would be good to figure out. Is it just that you have emscripten installed for example?
That it also affects 0.16.0 suggests it isnt a new regresion, so I don't consider it a blocker for this release, but defintely a good thing to address in the next release which might get accelerated depending on the precise issue, as I agree its not great. I was under the impression those bits were being built in CI, but this suggests otherwise, so if not and they also arent working we probably need to have a discussion around what to do with them (in its own thread). Robbie On 3 February 2017 at 18:27, Ganesh Murthy <[email protected]> wrote: > +1 > > * Verified signatures > * Ran Qpid Dispatch unit tests successfully > > I got down the bits from > https://dist.apache.org/repos/dist/dev/qpid/proton/0.17.0-rc1/ and proceeded > to build without disabling any binding. > > I saw this error in cmake - > > CMake Error at proton-c/bindings/javascript/CMakeLists.txt:177 (add_library): > Cannot find source file: > > /home/gmurthy/opensource/qpid-proton-0.17.0/proton-c/src/object/object.c > > Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp > .hxx .in .txx > > > > CMake Error: CMake can not determine linker language for target: > qpid-proton-bitcode > > CMake Error: Cannot determine link language for target "qpid-proton-bitcode". > > This comes from the Javascript binding being ON and goes away if turned off. > The same problem also exists with proton 0.16 > > Earlier, if the javascript binding was ON and if emscripten program was not > found, it would simply skip building the js binding but now it throws the > above error. > > Any newbie who builds proton will hit this problem will be confused. > > Thoughts? > > (In any case, I am giving a +1 because the above stated problem does not > affect the way we use proton in dispatch) > > Thanks. > > ----- Original Message ----- >> From: "Robbie Gemmell" <[email protected]> >> To: [email protected] >> Sent: Friday, February 3, 2017 12:35:47 PM >> Subject: [VOTE] Release Qpid Proton 0.17.0 >> >> Hi folks, >> >> I have put together a first spin for a 0.17.0 Qpid Proton release, >> please test it and vote accordingly. >> >> Note that Proton-J is now independently released, its vote is also under way. >> >> The source archive can be grabbed from: >> https://dist.apache.org/repos/dist/dev/qpid/proton/0.17.0-rc1/ >> >> The JIRAs currently assigned are [still in need of major cleanup]: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720&version=12338663 >> >> It is tagged as 0.17.0-rc1. >> >> Regards, >> Robbie >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
