I kicked the tyres as follows: - Verified the signature and checksums. - Ran RAT to verify licence headers, result (see below) is good in terms of files being licenced however it does show some things (more below). - Gave things a build (against proton-c master/0.18.0).
General question: are the proton tests dependent on proton master/0.18.0? Being lazy, I didn't try earlier versions as I had master installed, I just noted there didnt seem to be noted enforcement of the version used. If they do need it we should definitely wait for it to release. However even if they aren't it perhaps feels like it might still be a good idea to wait and align with it at this stage, given I'd guess thats mainly what has actually been getting tested with it of late? I noticed some issues that need fixed before release, and some things that I think could be improved before release: - You will need to update https://dist.apache.org/repos/dist/release/qpid/KEYS to add your key so folks can verify the signature. I used https://people.apache.org/keys/group/qpid.asc to get your key for now. - Can you change it to have a SHA512 checksum in a .sha512 file, rather than a SHA1, to match the ASF release policy recommendations and our other recent releases. - I think using https://dist.apache.org/repos/dist/dev/qpid/interop-test/ would be nicer and more consistent with all the existing component dirs, rather than the added https://dist.apache.org/repos/dist/dev/qpid/qpid-interop-test - The RAT output reveals a lot of surprising files. For examples there is around 15 files about testing dtx, which it isn't even defined how to with the protocol yet. Some of the clients with related files also dont even support [local] transactions yet I believe. I think it would be a lot better if those files were removed for now. - The build pom specifies the v17 apaache parent, whereas all the other components have used v18 for some time, so this should be updated to align various plugin versions. I've made that change on master. - The pom versions are still SNAPSHOT, they need updated before the release is cut. Something like this would work: mvn org.codehaus.mojo:versions-maven-plugin:2.4:set -DnewVersion=0.1.0 - The JMS shim defines a SNAPSHOT dependency on qpid-jms. Releases should use released dependencies. - The JMS shim defines dependency on JMS 2.0 and JMS 1.1 which seems odd (and the latter is even noted as being obsolete in the pom) - The dependency version management details should probably be consolidated to the parent, with a nice property that can be overriden on the command line to pick versions. See any of the other java components for example. - I think the Quickstart instructions need an overhaul before release: The instructions indicate several times that you must 'install' Qpid JMS before using. This makes little sense unless specifically testing changes you have made to the JMS client on master, thats about the only typical time a user would need to build and install the client. In other cases its just going to be retreived from maven central (or the apache snapshots repo) automatically when actually utilised. Given the requirement to build and install the interop tests (which it seems install a fat jar containing the client dependency) before running that should all just be seemless normally. The instructions make it out to be way more complicated than it actually is. Even ignoring that, the actual steps given for installing the JMS client also have issues. First they direct people to build the source repo master, when steps for using a release tag would be better as we dont direct users to non-releases as a matter of course. Next, the instructions detail that the client is available to install from the Fedora 26 package repository, when actually following that instruction would result in installing a positively ancient version of the client into some fedora specific locations on the filesystem that wont even get used by a regular downloaded Maven install (not sure if it will if you use Fedoras packaged maven, maybe it does some very ugly overriding to allow it). Thats overlooking that it is already much older than the test shims declared *snapshot* dependency on the client which means it cant be used anyway. The "## 3. Build and install qpid-interop-test" instructions includes cloning the repo, which seems redundant as the person already got this package (or have the repo checked out already) and so dont need it. We also shouldnt direct regular users toward non-releases as a matter of course. The repo itself is mentioned in the readme if folks need it. I think the Artemis instructions in "## 2. Obtaining a broker" are out of date. The configuration update you are directed to apply already seems to be present by default. # RAT output: ***************************************************** Summary ------- Generated at: 2017-09-25T11:16:43+01:00 Notes: 3 Binaries: 0 Archives: 0 Standards: 126 Apache Licensed: 126 Generated Documents: 0 JavaDocs are generated, thus a license header is optional. Generated files do not require license headers. 0 Unknown Licenses ***************************************************** Files with Apache License headers will be marked AL Binary files (which do not require any license headers) will be marked B Compressed archives will be marked A Notices, licenses etc. will be marked N AL qpid-interop-test-0.1-rc1/CMakeLists.txt N qpid-interop-test-0.1-rc1/LICENSE N qpid-interop-test-0.1-rc1/NOTICE AL qpid-interop-test-0.1-rc1/QUICKSTART.md AL qpid-interop-test-0.1-rc1/README.md AL qpid-interop-test-0.1-rc1/config.sh.in AL qpid-interop-test-0.1-rc1/get-proj-ver AL qpid-interop-test-0.1-rc1/get-python-dir-name AL qpid-interop-test-0.1-rc1/pom.xml AL qpid-interop-test-0.1-rc1/setup.py AL qpid-interop-test-0.1-rc1/CMakeModules/FindProton.cmake AL qpid-interop-test-0.1-rc1/CMakeModules/FindProtonCpp.cmake AL qpid-interop-test-0.1-rc1/docs/CMakeLists.txt AL qpid-interop-test-0.1-rc1/docs/Shim_HOWTO.txt AL qpid-interop-test-0.1-rc1/docs/Test_HOWTO.txt AL qpid-interop-test-0.1-rc1/docs/qpid-interop-test-devel-overview.txt AL qpid-interop-test-0.1-rc1/docs/users-guide.txt AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/CMakeLists.txt AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Receiver/App.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Receiver/Receiver.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Receiver/Receiver.csproj.in AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Receiver/packages.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Receiver/Properties/AssemblyInfo.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Sender/App.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Sender/Sender.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Sender/Sender.csproj.in AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Sender/packages.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_large_content_test/Sender/Properties/AssemblyInfo.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Receiver/App.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Receiver/Receiver.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Receiver/Receiver.csproj.in AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Receiver/packages.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Receiver/Properties/AssemblyInfo.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Sender/App.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Sender/Sender.cs AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Sender/Sender.csproj.in AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Sender/packages.config AL qpid-interop-test-0.1-rc1/shims/amqpnetlite/src/amqp_types_test/Sender/Properties/AssemblyInfo.cs AL qpid-interop-test-0.1-rc1/shims/qpid-jms/CMakeLists.txt AL qpid-interop-test-0.1-rc1/shims/qpid-jms/pom.xml AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_dtx_test/Receiver.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_dtx_test/Sender.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_hdrs_props_test/Receiver.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_hdrs_props_test/Sender.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_large_content_test/Receiver.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_large_content_test/Sender.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_messages_test/Receiver.java AL qpid-interop-test-0.1-rc1/shims/qpid-jms/src/main/java/org/apache/qpid/qpid_interop_test/jms_messages_test/Sender.java AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/CMakeLists.txt AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/AmqpReceiverBase.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/AmqpReceiverBase.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/AmqpSenderBase.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/AmqpSenderBase.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/AmqpTestBase.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/AmqpTestBase.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/JmsTestBase.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/JmsTestBase.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/QpidItErrors.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/QpidItErrors.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_dtx_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_dtx_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_dtx_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_dtx_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_features_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_features_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_features_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_features_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_large_content_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_large_content_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_large_content_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_large_content_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_types_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_types_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_types_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/amqp_types_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_dtx_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_dtx_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_dtx_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_dtx_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_hdrs_props_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_hdrs_props_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_hdrs_props_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_hdrs_props_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_large_content_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_large_content_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_large_content_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_large_content_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_messages_test/Receiver.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_messages_test/Receiver.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_messages_test/Sender.cpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-cpp/src/qpidit/jms_messages_test/Sender.hpp AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/CMakeLists.txt AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_dtx_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_dtx_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_features_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_features_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_large_content_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_large_content_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_types_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/amqp_types_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_dtx_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_dtx_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_hdrs_props_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_hdrs_props_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_large_content_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_large_content_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_messages_test/Receiver.py AL qpid-interop-test-0.1-rc1/shims/qpid-proton-python/src/jms_messages_test/Sender.py AL qpid-interop-test-0.1-rc1/shims/rhea-js/CMakeLists.txt N qpid-interop-test-0.1-rc1/shims/rhea-js/amqp_types_test/README AL qpid-interop-test-0.1-rc1/shims/rhea-js/amqp_types_test/Receiver.js AL qpid-interop-test-0.1-rc1/shims/rhea-js/amqp_types_test/Sender.js AL qpid-interop-test-0.1-rc1/src/python/not_yet_impl/amqp_dtx_test.py AL qpid-interop-test-0.1-rc1/src/python/not_yet_impl/amqp_features_test.py AL qpid-interop-test-0.1-rc1/src/python/not_yet_impl/jms_dtx_test.py AL qpid-interop-test-0.1-rc1/src/python/not_yet_impl/jms_large_content_test.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/__init__.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/amqp_large_content_test.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/amqp_types_test.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/broker_properties.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/interop_test_errors.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/jms_hdrs_props_test.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/jms_messages_test.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/jms_types.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/shims.py AL qpid-interop-test-0.1-rc1/src/python/qpid_interop_test/test_type_map.py AL qpid-interop-test-0.1-rc1/utils/pom.xml AL qpid-interop-test-0.1-rc1/utils/src/main/java/org/apache/qpid/qpid_interop_test/obj_util/BytesToJavaObj.java AL qpid-interop-test-0.1-rc1/utils/src/main/java/org/apache/qpid/qpid_interop_test/obj_util/JavaObjToBytes.java ***************************************************** Robbie On 19 September 2017 at 15:56, Kim van der Riet <[email protected]> wrote: > Hi, > > I have put together a candidate release for qpid-interop-test v 0.1. Please > 'kick the tires' and give it a test. Feedback and issues would be welcome. > > The source can be obtained from: > https://dist.apache.org/repos/dist/dev/qpid/qpid-interop-test/0.1-rc1/ > > Instructions for building and installation are in QUICKSTART.md. > > If there is no negative feedback or any issues raised, I will propose a vote > for release on Monday Sep. 25. > > Thanks, > Kim > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
