Hi, all. I've been attempting to get Qpid C++ in shape for a release. I need some review for some of the changes I've proposed (got some already from Robbie - thanks) and some help with test failures.
The change that needs particular review attention: https://github.com/apache/qpid-cpp/pull/10/commits/84e8001023e3a12a1032eafd7a8ea7719c47d627 The broader set of changes I have lined up: https://github.com/apache/qpid-cpp/pull/10 The test failures I'm seeing on Fedora 26: On Fedora 26 x86-64 The following tests FAILED: 18 - ha_tests (Failed) 26 - ssl_tests (Failed) ## Details for 'ha_tests' 18: ha_tests.ReplicationTests.test_auth ............................................................................................. fail 18: Error during test: Traceback (most recent call last): 18: File "/usr/bin/qpid-python-test", line 340, in run 18: phase() 18: File "/home/jross/code/qpid-cpp-ssorj/bld/src/tests/ha_tests.py", line 633, in test_auth 18: s0.sender("ex").send("foo"); 18: File "/home/jross/code/qpid-cpp-ssorj/bld/bindings/qpid/python/qpid_messaging.py", line 812, in sender 18: s = self._sender(target) 18: File "/home/jross/code/qpid-cpp-ssorj/bld/bindings/qpid/python/qpid_messaging.py", line 771, in _sender 18: return _qpid_messaging.Session__sender(self, *args) 18: UnauthorizedAccess: Link detached by peer with amqp:unauthorized-access: ACL denied access request to ex from anonymous@QPID (/home/jross/code/qpid-cpp-ssorj/src/qpid/broker/amqp/Authorise.cpp:152) 2017-09-28 10:29:55 [Security] info SASL: Mechanism list: ANONYMOUS PLAIN 2017-09-28 10:29:55 [Security] info SASL: Starting authentication with mechanism: ANONYMOUS 2017-09-28 10:29:55 [Security] info qpid.0.0.0.0:53173-127.0.0.1:58096 Authenticated as anonymous@QPID 2017-09-28 10:29:55 [HA] info aba36a70(active) Accepted client connection qpid.0.0.0.0:53173-127.0.0.1:58096 qpid-python-tes(7561) 2017-09-28 10:29:55 [HA] debug aba36a70(active) Created queue q replication: all 2017-09-28 10:29:55 [HA] debug aba36a70(active) Guard of q at 56c9dd56@tcp: 127.0.0.1:57887: Guarded: front 1, back 0, guarded 1 2017-09-28 10:29:55 [HA] debug aba36a70(active) Subscription to q at 56c9dd56@tcp:127.0.0.1:57887: Subscribed: primary [1,0]={ }, guarded 1, backup (keep { }, drop { }) 2017-09-28 10:29:55 [HA] debug aba36a70(active) Subscription to q at 56c9dd56@tcp:127.0.0.1:57887: Caught up at 1 2017-09-28 10:29:55 [HA] debug aba36a70(active) Created exchange ex replication: all 2017-09-28 10:29:55 [Protocol] error Error on attach: ACL denied access request to ex from anonymous@QPID (/home/jross/code/qpid-cpp-ssorj/src/qpid/broker/amqp/Authorise.cpp:152) ## Details for 'ssl_tests' 26: ++ /home/jross/code/qpid-cpp-ssorj/src/tests/ping_broker -b amqps:// 127.0.0.1:37029 --ssl-trustfile=/home/jross/code/qpid-cpp-ssorj/bld/src/tests/test_cert_dir/ca_cert.pem 26: + Failed: ConnectError - '[SSL:' 'CERTIFICATE_VERIFY_FAILED]' certificate verify failed '(_ssl.c:661)' 26: /home/jross/code/qpid-cpp-ssorj/bld/src/tests/run_ssl_tests: line 299: Failed:: command not found (The test code here is broken. It's trying to execute the error string.)
