-1 - There appear to be several changes in the archive, made since the previous cut, which are not yet in the source repository. - The floating version range defined for the JMS client dependency, as opposed to a fixed version, still results in it ending up using a SNAPSHOT dependency by default. This presumably happens since our builds inherits knowledge of the snapshots repo from the apache parent, meaning it is available and gets used in resolving the range. To use a range for that dependency, the snapshots repo definition would need to be overridden and disabled by default, perhaps wired with a toggle to enable in the cases using it is desired. However, in general I think the range should just be removed, since it results in a build that will change behaviour over time without user intervention, which doesnt seem desirable. Anyone who wants that behaviour could still opt-in to it using trivial config on the command line for the related version property.
Some other less important issues which could be addressed in future, but would probably be best handled now: - I think the version should be updated to 0.1.0 rather than 0.1, for consistency with all the other components. Its actually internally inconsistent currently, using 0.1.0 in the pom, but 0.1 in the python setup bits. - The Java shim and util source files aren't in the correct directories based on their stated packages, which causes certain tasks to fail. They are under package org.apache.qpid.interop_test and so should be under <foo>/org/apache/qpid/interop_test/ but are actually under <foo>org/apache/qpid/qpid_interop_test/ Finally, one 'nice to have' at some point, though if it is as simple as it seems I'd also do it now: - The JSON[-P] dependencies used are permittable but would need called out as CDDL if we ever made a bundle. Though I doubt we will, if possible it still seems like it would be better to consider using the ALv2 bits from Apache Johnzon and geronimo-specs going forward instead. Robbie On 3 October 2017 at 20:53, Kim van der Riet <[email protected]> wrote: > The release candidate is at > https://dist.apache.org/repos/dist/dev/qpid/interop-test/0.1-rc2/ > > Sorry for the incorrect URL. > > > On 10/03/2017 03:51 PM, Kim van der Riet wrote: >> >> This is the first official release of the test tool qpid-interop-test. >> >> I have provided a release candidate at: >> https://dist.apache.org/repos/dist/dev/qpid/qpid-interop-test/0.1-rc2/ >> >> Instructions for building and installation are in QUICKSTART.md. >> >> Please test and vote. >> >> Thanks, >> Kim van der Riet >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
