Overall it's good. Things to consider - none are essential:
drop 'binding/', put the language bindings directly in the root dir. It's pretty obvious what they are - ruby, go, cpp etc. Possibility: a "c" or "core" subdir rather than having the core src/ directly in root - clarify that the c-core is a separate "module". It is a runtime dependency for the bindings but still separate and self-contained. I'm not sure about this but it does seem more "balanced" somehow. src/messenger still there - oversight, or do we need to hold onto this? src/reactor - python is the only remaining user of this if we ditch perl/php, more reasons to fix that. Practical point - there may be some extra tweaks to keep our `go get` setup working when the go subdir moves. I don't think the move will have any immediate impact, but we may need care & updated instructions on the next merge out to the "go1" branch On Thu, Mar 8, 2018 at 12:15 PM, Justin Ross <[email protected]> wrote: > Hi, all. After we split Proton J out of Proton, the existing Proton C > source tree no longer made sense. This proposed change moves the > proton-c/* content to the top level and generally aligns the source tree > with conventions we use in some of our other code bases. > > It also removes bindings, APIs, docs, and test code that have been > deprecated for some time, are no longer used, or are not maintained. > > The tree after the reorg: > https://github.com/ssorj/qpid-proton/tree/ssorj-reorganize-the-source-tree > > Pull requests (these build on each other): > https://github.com/apache/qpid-proton/pull/136 - Remove deprecated > bindings > and APIs > https://github.com/apache/qpid-proton/pull/138 - Remove obsolete docs and > test code > https://github.com/apache/qpid-proton/pull/140 - Reorganize the source > tree > > CI results (passing apart from an unrelated OS X issue and a known > intermittent failure on Windows): > https://travis-ci.org/ssorj/qpid-proton > https://ci.appveyor.com/project/ssorj/qpid-proton >
