+1 * Validated signatures and checksums * ran apache rat-check * built from source distribution artefact and ran all tests (mvn verify with Java 1.8.0_162 on Mac OS X 10.11.6) * ran Broker-J's JMS test suite (qpid-systests-jms_2.0 & qpid-systests-jms_1.1 - master) against the staged Maven artefacts
However, I ran into a problem testing QPIDJMS-367 with Google OAuth and Broker-J. Google's access_tokens from /oauth2/v4/token use characters drawn from outside Base64's 64 character set. RFC 6749[1] defines an access_token element as within %x20-7E, so the code within org.apache.qpid.jms.sasl.XOauth2Mechanism#isApplicable is too restrictive. On temporarily hacking out the restriction, authentication worked correctly. This is something that should be fixed, but is not so critical to me not to +1 this release. Thoughts? [1] https://tools.ietf.org/html/rfc6749#page-73 On 23 March 2018 at 13:02, Oleksandr Rudyy <oru...@gmail.com> wrote: > +1 > > * Validated signatures and checksums > * Built from source and ran the tests > * Ran Broker-J master system tests against staged artefacts using > profiles java-mms.1-0 and java-bdb.1-0 > * Built sample application publishing messages into Broker-J > 7.0.3-SNAPSHOT using staged artefacts > > > On 22 March 2018 at 18:44, Robbie Gemmell <robbie.gemm...@gmail.com> wrote: >> Hi folks, >> >> I have put together a spin for a 0.31.0 Qpid JMS client release, >> please give it a test out and vote accordingly. >> >> The source and binary archives can be grabbed from: >> https://dist.apache.org/repos/dist/dev/qpid/jms/0.31.0-rc1/ >> >> The maven artifacts are also staged for now at: >> https://repository.apache.org/content/repositories/orgapacheqpid-1133 >> >> The JIRAs assigned are: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314524&version=12342832 >> >> Regards, >> Robbie >> >> P.S. If you want to test it out using maven (e.g with the examples >> src, or your own things), you can temporarily add this to your poms to >> access the staging repo: >> >> <repositories> >> <repository> >> <id>staging</id> >> >> <url>https://repository.apache.org/content/repositories/orgapacheqpid-1133</url> >> </repository> >> </repositories> >> >> The dependency for the client itself would then be: >> >> <dependency> >> <groupId>org.apache.qpid</groupId> >> <artifactId>qpid-jms-client</artifactId> >> <version>0.31.0</version> >> </dependency> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org >> For additional commands, e-mail: users-h...@qpid.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
