+1 with comments. - The directory linked below is still for RC3. I have deleted the old RC3 files from the repo to avoid further mixup on that. I assume it was meant to be https://dist.apache.org/repos/dist/dev/qpid/interop-test/0.2.0-rc4 and so tested that. If not, consider my vote rescinded. Either way, for procedure it would be good if you can confirm the correct link. - Not a deal breaker, but it is unfortunate that the tests still use the 0.34.0 JMS client by default, as that version had a perf regression on Windows. It should be updated (0.36.0 now out) for any further RC created. - It seems you still have to update your ASF profile details to list your new key, as https://people.apache.org/keys/committer/kpvdr.asc and https://people.apache.org/keys/group/qpid.asc appear to be listing your previous one. - The maven RAT plugin config could perhaps do with updating, such that running mvn apache-rat:check doesnt fail due to the 3 JSON test files present (or if the JSON parser being used allows comments then the files could have the licence header added instead). - As noted previously, having a branch named 0.2.0 is awkward as the final tag will be 0.2.0 and they will clash. Naming the branch 0.2.x would be more typical.
I verified the sig and checksum files, checked for LICENCE+NOTICE, ran the build and did a local install, and gave things a try by running "python -m qpid_interop_test.jms_messages_test --exclude-shim ProtonPython3" (against a source-installed proton 0.24.0 built for python2 only, and an ActiveMQ 5.15.5'ish broker). Robbie On Tue, 14 Aug 2018 at 14:52, Kim van der Riet <[email protected]> wrote: > > Hi, > > I have assembled a proposed release for Apache Qpid Interop Test 0.2.0 > (RC4). The Python path issue found in RC3 was fixed. Please try it out > and test it, then vote accordingly on this thread. > > The files can be obtained from: > https://dist.apache.org/repos/dist/dev/qpid/interop-test/0.2.0-rc3/ > > NOTE: Please freshen your keys before verifying the signature, as this > release was signed using a new key. > > The JIRAs included in this release are: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318621&version=12342084 > > > This release is tagged in git as 0.2.0-rc4 on the 0.2.0 branch. > > Thanks, > Kim > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
