+1 (with note)

* Fedora 27 - running version at release tag for several days
* Checksums check
* passes self test (note)

Note: Building from source, not installed, and running tests:

  mkdir build
  cd    build
  cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/opt/local ..
  make -j 8
  make test

fails python-tox-test. To see what's wrong: 

  ctest -VV -R python-tox-test

shows:

  33: 
/home/chug/tmp/proton-0.26-rc2/qpid-proton-0.26.0/build/python/dist/src/core/message.c:118:24:
 
      error: ‘HEADER_PRIORITY_DEFAULT’ undeclared (first use in this function)
  33:    if (msg->priority != HEADER_PRIORITY_DEFAULT) {

It looks like the header file that defines HEADER_PRIORITY_DEFAULT has an issue.

By running 'make' again python-tox-test passes. I suspect that there is some 
kind of race with doing 'make -j 8' if running make again fixes things. This 
error does not always happen. I can do clean cmake/build and it works just 
fine. I'll file a jira.

Since this is just a build/test issue that has no effect on the main proton 
mission I approve the release.



----- Original Message -----
> From: "Robbie Gemmell" <[email protected]>
> To: [email protected]
> Sent: Thursday, October 4, 2018 8:27:23 AM
> Subject: [VOTE] Release Apache Qpid Proton 0.26.0 (RC2)
> 
> Hi folks,
> 
> I have put together a second spin for a Qpid Proton 0.26.0 release,
> please give it a test out and vote accordingly.
> 
> The files can be grabbed from:
> https://dist.apache.org/repos/dist/dev/qpid/proton/0.26.0-rc2/
> 
> The JIRAs assigned are:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720&version=12344005
> 
> The changes since RC1 were made via PROTON-1946 and PROTON-1947 (fixup
> sub tasks for PROTON-1935).
> 
> It is tagged as 0.26.0-rc2.
> 
> Regards,
> Robbie
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to