Rob, I agree. It is definitely not a blocker for release.
Alex On Fri, 5 Jul 2019 at 11:25, Rob Godfrey <[email protected]> wrote: > On Fri, 5 Jul 2019 at 12:19, Oleksandr Rudyy <[email protected]> wrote: > > > Hi Rob, > > > > Thanks for confirmation. > > I will port QPID-8150 changes into the 7.0.x branch. Somehow, I missed to > > merge them into 7.0 :( > > > > > I certainly don't think it is a blocker for this release, the test > "failure" is simply down to how long (failed) dns resolution takes on the > machine running the test. > > -- Rob > > > > Kind Regards, > > Alex > > > > On Fri, 5 Jul 2019 at 11:16, Rob Godfrey <[email protected]> > wrote: > > > > > Hi Alex, > > > > > > thanks for finding that JIRA for me - I knew that I'd fixed this at > some > > > point in the past. > > > > > > Just to confirm that that fixes the test for me. So I'm +1 on the > > release > > > (perhaps we should apply that fix to the 7.0.x branch in case we do any > > > more releases from there) > > > > > > Build from src, ran tests (passing with the fix to the test > configuration > > > applied) > > > Started the broker and tested the web console. > > > > > > -- Rob > > > > > > > > > On Fri, 5 Jul 2019 at 12:09, Oleksandr Rudyy <[email protected]> wrote: > > > > > > > Gordon, > > > > > > > > Thanks for the logs. Though, there is nothing interesting there which > > > would > > > > shed light over the failure cause. > > > > > > > > The log file contain a record for receiving OPEN performative, and, > > after > > > > that, in 6 seconds the test fails. > > > > > > > > Rob reported QPID-8150 [1] about issues with time taken by hostname > > > > resolution. There are port host aliases configured in broker > > > configuration > > > > which are resolving host names. On some environments it take a lot of > > > time. > > > > It could be potential reason for the test failure. > > > > > > > > What is your environment? > > > > > > > > You can remove the hostname alias entry from the broker test > > > configuration > > > > to make sure that it does not impact the test. > > > > > > > > The diff is below > > > > > > > > $ git diff > > > > diff --git > > > > > > > > > > > > > > a/systests/protocol-tests-amqp-1-0/src/main/resources/config-protocol-tests.json > > > > > > > > > > > > > > b/systests/protocol-tests-amqp-1-0/src/main/resources/config-protocol-tests.json > > > > index 764ff891a..522fd5bea 100644 > > > > --- > > > > > > > > > > > > > > a/systests/protocol-tests-amqp-1-0/src/main/resources/config-protocol-tests.json > > > > +++ > > > > > > > > > > > > > > b/systests/protocol-tests-amqp-1-0/src/main/resources/config-protocol-tests.json > > > > @@ -47,9 +47,6 @@ > > > > "virtualhostaliases" : [ { > > > > "name" : "defaultAlias", > > > > "type" : "defaultAlias" > > > > - }, { > > > > - "name" : "hostnameAlias", > > > > - "type" : "hostnameAlias" > > > > }, { > > > > "name" : "nameAlias", > > > > "type" : "nameAlias" > > > > @@ -64,10 +61,6 @@ > > > > "name" : "defaultAlias", > > > > "type" : "defaultAlias", > > > > "durable" : true > > > > - }, { > > > > - "name" : "hostnameAlias", > > > > - "type" : "hostnameAlias", > > > > - "durable" : true > > > > }, { > > > > "name" : "nameAlias", > > > > "type" : "nameAlias", > > > > > > > > > > > > I hope that the above should fix the issue. > > > > > > > > Kind Regards, > > > > Alex > > > > > > > > [1] https://issues.apache.org/jira/browse/QPID-8150 > > > > > > > > > > > > On Fri, 5 Jul 2019 at 09:54, Gordon Sim <[email protected]> wrote: > > > > > > > > > On 05/07/2019 9:26 am, Oleksandr Rudyy wrote: > > > > > > Hi Gordon, > > > > > > > > > > > > Thanks for testing the release and reporting a test failure. > > > > > > > > > > > > The failed test sends open performative against non existing > > virtual > > > > host > > > > > > and expects to receive an "open" back containing an error > > > > > "amqp:not-found" > > > > > > within 6 seconds after sending "open". > > > > > > The failure occurred because "open" was not received within 6 > > > seconds. > > > > It > > > > > > could be environmental. For example, a long GC "stop the world" > > pause > > > > can > > > > > > cause it, or, environment in use could be slow. > > > > > > > > > > I did run all the tests a second time and again it failed on that > > > > > specific test only. (Not that that necessarily rules out your > > > hypothesis) > > > > > > > > > > > The test logs could provide more details about test execution. > > > > > > > > > > > > If you still have a test log file > > > > > > > > > > > > > > > > > > > > > ./systests/protocol-tests-amqp-1-0/target/surefire-reports/java-mms.1-0/TEST-org.apache.qpid.tests.protocol.v1_0.transport.connection.OpenTest.failOpenOnNonExistingHostname.txt, > > > > > > could you please send it over? > > > > > > > > > > Attached > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > >
