On Thu, 5 Nov 2020 at 15:32, Jiri Daněk <jda...@redhat.com> wrote: > > Hello folks, > > (https://issues.apache.org/jira/browse/DISPATCH-1814 Apply autofixes to > resolve some flake8 code formatting issues) > > I have prior positive experience with autopep8, > https://pypi.org/project/autopep8/. It is a tool to automatically reformat > Python source code. It can either selectively reformat to fix only a > specific flake8 warning, or it can just do it all in one go. > > What do you think about running this on the Qpid Proton and Qpid Dispatch > code? Is there a good time when to do it? Would it be better to fix each > warning individually, in its own commit (to simplify manual review), or do > it all in one commit (to simplify git history, and spend less time on it)? > > I am personally in favour of a single commit in which to do all the > whitespace changes in one go. I've always found autopep8 to work reliably. > > Regarding potential issues, whitespace changes would affect ongoing work in > progress (although the autoformatter can be run on the PRs as well), so it > seems to me that a good time to land this would be after a release. > -- > Mit freundlichen Grüßen / Kind regards > Jiri Daněk
I'll leave 'what to do?' position to the folks with more knowledge / actually working on the bits, but I think you nailed the answer to 'when to do it?' aspect already: if doing anything like this an agreed point just after a release seems to be clearly the best time for such things. Robbie --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
