Np. Though it does suggest some update/rework of the CI jobs is in order, since the test issues should have been caught earlier. That in addition to perhaps preparing for removal of the Travis based jobs when Infra cease paying for Travis at the end of December.
On Fri, 11 Nov 2022 at 15:54, Tomas Vavricka <vavr...@apache.org> wrote: > > Hi Robbie, > > thank you very much for testing and comments. > > The points mentioned should be fixed in main branch. > > I will try to prepare RC2 next week (if no more issues). > > Regards, > Tomas > > On 2022/11/11 13:25:27 Robbie Gemmell wrote: > > One further issue noticed now the earlier test issue was resolved on > > main and the build got further this time: > > > > Another test failing on Java 17, probably related to > > https://issues.apache.org/jira/browse/QPID-8586 as it seems the same > > type of failure and area. > > > > mvn clean verify -DskipITs=false > > > > [INFO] Running org.apache.qpid.systest.disttest.endtoend.EndToEndTest > > [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time > > elapsed: 7.784 s <<< FAILURE! - in > > org.apache.qpid.systest.disttest.endtoend.EndToEndTest > > [ERROR] > > testHillClimbing(org.apache.qpid.systest.disttest.endtoend.EndToEndTest) > > Time elapsed: 0.073 s <<< ERROR! > > java.lang.NullPointerException: Cannot invoke > > "javax.script.ScriptEngine.eval(java.io.Reader)" because "engine" is > > null > > at > > org.apache.qpid.systest.disttest.endtoend.EndToEndTest.runController(EndToEndTest.java:288) > > at > > org.apache.qpid.systest.disttest.endtoend.EndToEndTest.testHillClimbing(EndToEndTest.java:226) > > > > > > > > On Wed, 9 Nov 2022 at 13:03, Robbie Gemmell <robbie.gemm...@gmail.com> > > wrote: > > > > > > I know the vote was already cancelled, but I had started testing and > > > so continued. Given that, my vote would have been -1 due some niggles > > > needing fixed. > > > > > > Quick list, with expansions later: > > > - Some licence file updates needed for the binary distribution. > > > - Possible extraneous tests jar file in the binary distribution. > > > - The binary distribution doesnt start on Java 17 due to a removed GC > > > option, same option causes a warning on Java 11. > > > - The E2E Conversion tests fail for me. > > > - I would delete the 9.0.x branch and use main. > > > > > > > > > ## Licence file issues and potentially stray jar in distribution: > > > - ASM / ASM-Tree was added to the binary distro and should be > > > mentioned in LICENCE given it isnt ASLv2; prodding this is part of > > > what dependencies reference file is for, LICENCE update should be made > > > at same time as adding the deps. > > > - A couple of logback -db jars added, names should be noted in LICENCE > > > with the others (assuming using the same licence). > > > - There is a possibly extraneous logback tests jar added to the > > > distribution, the dep should either be removed wherever it is coming > > > in (if not actually needed), or also covered in LICENCE. > > > > > > > > > ## The broker distribution cant start on Java 17 out the box due to > > > the default options set from JAVA_GC: > > > This seems unreasonable at this stage, especially for a new major this > > > long after Java 17 came out, and would be particularly odd given the > > > overall changes look to include JDK17 compatibility fixes. > > > > > > Info: QPID_JAVA_GC not set. Defaulting to JAVA_GC > > > -XX:+UseConcMarkSweepGC -XX:+HeapDumpOnOutOfMemoryError > > > Info: QPID_JAVA_MEM not set. Defaulting to JAVA_MEM -Xmx512m > > > -XX:MaxDirectMemorySize=1536m > > > Unrecognized VM option 'UseConcMarkSweepGC' > > > Error: Could not create the Java Virtual Machine. > > > Error: A fatal exception has occurred. Program will exit. > > > > > > The same option also causes a warning when starting on Java 11 since > > > it was deprecated in Java 9. > > > > > > > > > ## E2E Conversion tests fail: > > > > > > Perhaps something to do with the updates of the tests maven-based > > > dependencies, and compatibility with other deps and/or the maven > > > version running the build. Failed for me on Java 17 and 11, using > > > Maven 3.8.6 and 3.8.5. > > > > > > Quick path to the failure without installing the dependent modules is: > > > mvn clean verify -DskipTests -DskipITs=false -am -pl > > > "org.apache.qpid:qpid-systests-end-to-end-conversion-tests" > > > > > > Failures are all like: > > > > > > [ERROR] > > > correlationIdAsBytes(org.apache.qpid.systests.end_to_end_conversion.SimpleConversionTest) > > > Time elapsed: 0.22 s <<< ERROR! > > > java.util.concurrent.ExecutionException: > > > com.google.common.util.concurrent.ExecutionError: > > > java.lang.NoSuchMethodError: 'java.util.List > > > org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksumAlgorithmFactories()' > > > at > > > org.apache.qpid.systests.end_to_end_conversion.SimpleConversionTest.performTest(SimpleConversionTest.java:548) > > > at > > > org.apache.qpid.systests.end_to_end_conversion.SimpleConversionTest.performSimpleTest(SimpleConversionTest.java:538) > > > at > > > org.apache.qpid.systests.end_to_end_conversion.SimpleConversionTest.correlationIdAsBytes(SimpleConversionTest.java:184) > > > Caused by: com.google.common.util.concurrent.ExecutionError: > > > java.lang.NoSuchMethodError: 'java.util.List > > > org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksumAlgorithmFactories()' > > > Caused by: java.lang.NoSuchMethodError: 'java.util.List > > > org.eclipse.aether.spi.connector.layout.RepositoryLayout.getChecksumAlgorithmFactories()' > > > > > > > > > ## Delete the 9.0.x branch: > > > > > > More of an aside/comment than issue with the release itself. I'd > > > suggest not using a 9.0.x branch. Release from main. > > > > > > The branch can be created later if it's ever actually needed, if main > > > should ever need to diverge from 9.0.x related changes while there are > > > still overlapping 9.0.x releases expected. Making *every* commit going > > > into future 9[.0].x releases need to go on main and then get picked to > > > the branch is simply unnecessary overhead and additional state to > > > track when doing releases. It might also require setting up additional > > > CI jobs, e.g in Jenkins, where jobs already exist for main but dont > > > for the new branch. > > > > > > > > > > > > > > > On Tue, 8 Nov 2022 at 13:39, .. ... <vavricka.to...@gmail.com> wrote: > > > > > > > > Hi all, > > > > > > > > I built release artefacts for Qpid Broker-J version 9.0.0 RC1. > > > > Please, give them a test out and vote accordingly. > > > > > > > > The source and binary archives can be found at: > > > > https://dist.apache.org/repos/dist/dev/qpid/broker-j/9.0.0-rc1/ > > > > > > > > The maven artifacts are also staged at: > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1249/ > > > > > > > > The new version brings a number of improvements and bug fixes. > > > > You can find the full list of JIRAs included in the release here: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310520&version=12348607 > > > > > > > > Regards, > > > > Tomas > > > > > > > > P.S. For testing of maven broker staging repo artefacts, please add > > > > into to your project pom the staging repo as below: > > > > > > > > <repositories> > > > > <repository> > > > > <id>staging</id> > > > > <url> > > > > https://repository.apache.org/content/repositories/orgapacheqpid-1249/</url> > > > > </repository> > > > > </repositories> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > For additional commands, e-mail: users-h...@qpid.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org For additional commands, e-mail: users-h...@qpid.apache.org
