Hi,

The migration to logback 1.4.5 changed the signature of
Configurator#configure() from being void to returning ExecutionStatus.
Originally NoopConfigurator#configure() was returning
ExecutionStatus.NEUTRAL indeed, but during the preparation of release
9.1.0 it was discovered that this value leads to the chaining of
broker's NoopConfigrator and logback's BasicConfigurator resulting in
broker log duplication. Therefore the return value was changed to
ExecutionStatus.DO_NOT_INVOKE_NEXT_IF_ANY.

The fix for the issue described may require some further analysis.
Would you please create a JIRA to track this issue?

Best regards,
Daniil Kirilyuk

On Tue, 24 Oct 2023 at 14:47, Adrian Pasternak
<apaster...@fandom.com.invalid> wrote:
>
> Hi,
>
> We are using qpid-broker-j version 9.1.0 as a dependency in our project.
>
> It seems that just adding qpid-broker as a dependency:
> <dependency>
>     <groupId>org.apache.qpid</groupId>
>     <artifactId>qpid-broker</artifactId>
>     <version>9.1.0</version>
> </dependency>
>
> Disables all logback logging in our application.
>
> I've debugged logback and found out that this behavior might be caused by a
> change:
> https://github.com/apache/qpid-broker-j/blame/9.1.0/broker-plugins/logging-logback/src/main/java/org/apache/qpid/server/logging/logback/NoopConfigurator.java#L33
>
> Is this an intended behavior?
>
> If not, and it's only a matter of changing the return value to eg. NEUTRAL,
> then I can prepare a GH PR with the fix.
>
> If this behavior is intended, or more changes are required, please let me
> know.
>
> Thank you.
>
> Best regards
> Adrian Pasternak

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org

Reply via email to