Hi Takeshita, many thanks for reporting. Can you submit this change as a PR? I can merge it thanks
El mar., 19 nov. 2019 a las 22:45, Takeshita Shoichiro (<[email protected]>) escribió: > Hi, the problem is solved. In addition to copySourcePathAssets, > source-path is required to point the image folder. > > Corrected asconfig.json: > > { > "config": "royale", > "compilerOptions": { > "debug": true, > "targets": ["JSRoyale"], > "source-map": true, > "source-path": [ > "src/main/royale", > "src/main/resources" > ] > }, > "additionalOptions": > "-remove-circulars -js-output-optimization=skipAsCoercions", > "copySourcePathAssets": true, > "files": > [ > "src/main/royale/DataGridExample.mxml" > ] > } > > On Sat, Nov 16, 2019 at 1:25 PM Takeshita Shoichiro <[email protected]> > wrote: > >> Hi, I opened an issue for this. Thanks. >> >> https://github.com/BowlerHatLLC/vscode-as3mxml/issues/427 >> >> On Fri, Nov 15, 2019 at 5:39 PM Carlos Rovira <[email protected]> >> wrote: >> >>> Hi, >>> >>> I suppose VSCode fill have some way to copy a folder, maybe as a task >>> that could be launched as pre step of a build or something like that. Or >>> maybe a VSCode plugin exists for that, don't know. That could be solutions >>> if VSCode AS3&MXML can't do it itself, or Josh decide is not a task to be >>> implemented there. >>> >>> just my 2... >>> >>> >>> >>> El vie., 15 nov. 2019 a las 6:09, Takeshita Shoichiro (< >>> [email protected]>) escribió: >>> >>>> Alex, thanks for your explanation. As suggested by Carlos, I will ask >>>> this on Github VS Code. >>>> >>>> 2019年11月15日(金) 14:05 Alex Harui <[email protected]>: >>>> >>>>> Hi T-San, >>>>> >>>>> >>>>> >>>>> The folder structure for examples/royale/DataGridExample are designed >>>>> to support Maven typical folders. The Ant and Maven scripts that build >>>>> the >>>>> example have to copy the assets because the src/main/resources folder is >>>>> not one the folders the publisher module copies automatically. >>>>> >>>>> >>>>> >>>>> So, if you are using VSCode with that folder structure, the compiler >>>>> will not copy the assets. I do not use VSCode so I don’t know if VSCode >>>>> can be taught to automatically copy those folders or not. >>>>> >>>>> >>>>> >>>>> HTH, >>>>> >>>>> -Alex >>>>> >>>>> >>>>> >>>>> *From: *Takeshita Shoichiro <[email protected]> >>>>> *Reply-To: *"[email protected]" <[email protected]> >>>>> *Date: *Thursday, November 14, 2019 at 4:36 PM >>>>> *To: *"[email protected]" <[email protected]> >>>>> *Subject: *Re: DataGridExample build with VS Code >>>>> >>>>> >>>>> >>>>> Alex and Harbs, >>>>> >>>>> >>>>> >>>>> I copied the folder structure from the Apache Royale distribution. >>>>> >>>>> >>>>> >>>>> ¥royale-asjs¥examples¥royale¥DataGridExample >>>>> >>>>> >>>>> >>>>> It contains ¥src¥main¥royale >>>>> >>>>> And ¥src¥main¥resources¥assets. >>>>> >>>>> >>>>> >>>>> Under assets folder, jpg files exist. >>>>> >>>>> >>>>> >>>>> I used the provided asconfig.json to build using VS code with MXML >>>>> extension. >>>>> >>>>> >>>>> >>>>> The problem is ¥resources¥assets folder is not copied into the output >>>>> folder. If I move assets folder under ¥src¥royale¥main, assets folder is >>>>> copied into the output folder. >>>>> >>>>> >>>>> >>>>> Thanks. >>>>> >>>>> >>>>> >>>>> 2019年11月15日(金) 6:53 Alex Harui <[email protected]>: >>>>> >>>>> IIRC, src/main and src/test are maven folder conventions. >>>>> >>>>> >>>>> >>>>> -Alex >>>>> >>>>> >>>>> >>>>> *From: *Harbs <[email protected]> >>>>> *Reply-To: *"[email protected]" <[email protected]> >>>>> *Date: *Thursday, November 14, 2019 at 1:51 PM >>>>> *To: *"[email protected]" <[email protected]> >>>>> *Subject: *Re: DataGridExample build with VS Code >>>>> >>>>> >>>>> >>>>> Why are you using main\royale at all? >>>>> >>>>> >>>>> >>>>> All your folders can reside directly in src. >>>>> >>>>> >>>>> >>>>> Harbs >>>>> >>>>> On Nov 14, 2019, at 4:11 PM, Takeshita Shoichiro <[email protected]> >>>>> wrote: >>>>> >>>>> >>>>> >>>>> Carlos, thanks. I've already tried it. Unfortunately, not work. >>>>> >>>>> >>>>> >>>>> If I move assets folder under \royale, it worked. (Images are shown) >>>>> >>>>> However, moving \resources\royale under \royale does not work. (Images >>>>> are not shown) >>>>> >>>>> >>>>> >>>>> \src\main\royale >>>>> | >>>>> |-assets >>>>> |-models >>>>> |-products >>>>> |-DataGridExample.mxml >>>>> |-MyInitialView.mxml >>>>> >>>>> >>>>> >>>>> On Thu, Nov 14, 2019 at 11:00 PM Carlos Rovira < >>>>> [email protected]> wrote: >>>>> >>>>> Hi Takeshita, >>>>> >>>>> >>>>> >>>>> maybe this could be what you are looking for? (I'm not using it so >>>>> don't know if it will work) : >>>>> >>>>> >>>>> >>>>> >>>>> https://github.com/BowlerHatLLC/vscode-as3mxml/wiki/asconfig.json#copysourcepathassets >>>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBowlerHatLLC%2Fvscode-as3mxml%2Fwiki%2Fasconfig.json%23copysourcepathassets&data=02%7C01%7Caharui%40adobe.com%7C17b50b2b31da43bb23ac08d76963d2f2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637093749772909921&sdata=ELefXGSCXaVGxHF%2B66G4exKGDp9u%2Bg07wOVFNxup6dQ%3D&reserved=0> >>>>> >>>>> >>>>> >>>>> HTH >>>>> >>>>> >>>>> >>>>> Carlos >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> El jue., 14 nov. 2019 a las 13:54, Takeshita Shoichiro (< >>>>> [email protected]>) escribió: >>>>> >>>>> Carlos and Piotr, thanks. >>>>> >>>>> I understand mvn and moonshine both have the configuration to copy >>>>> \resources\assets folder. >>>>> >>>>> I think the similar configuration is put in asconfig.json. I tried to >>>>> find the information but with no success. >>>>> >>>>> >>>>> ---------------------------------------------------------------------------------------------------- >>>>> mvn: >>>>> \apache-royale-0.9.7-bin-js\royale-asjs\examples\pom.xml >>>>> >>>>> <!-- Copy the resources to the compiler output directory --> >>>>> <plugin> >>>>> <groupId>org.apache.maven.plugins</groupId> >>>>> <artifactId>maven-resources-plugin</artifactId> >>>>> <version>3.1.0</version> >>>>> <executions> >>>>> <execution> >>>>> <id>copy-resources-debug</id> >>>>> <phase>validate</phase> >>>>> <goals> >>>>> <goal>copy-resources</goal> >>>>> </goals> >>>>> <configuration> >>>>> >>>>> <outputDirectory>${compiler.output-dir-debug}</outputDirectory> >>>>> <resources> >>>>> <resource> >>>>> <directory>src/main/resources</directory> >>>>> <filtering>true</filtering> >>>>> </resource> >>>>> </resources> >>>>> </configuration> >>>>> </execution> >>>>> </executions> >>>>> </plugin> >>>>> >>>>> moonshine: >>>>> >>>>> C:\apache-royale-0.9.7-bin-js\royale-asjs\examples\royale\DataGridExample\DataGridExample.as3proj >>>>> >>>>> <moonshineResourcePaths> >>>>> <class path="src/main/resources/assets"/> >>>>> </moonshineResourcePaths> >>>>> >>>>> >>>>> >>>>> On Thu, Nov 14, 2019 at 4:57 AM Piotr Zarzycki < >>>>> [email protected]> wrote: >>>>> >>>>> Just FYI: Moonshine is copying resources to the output if they are >>>>> pointed out in IDE. We have handled that on IDE sight. >>>>> >>>>> >>>>> >>>>> śr., 13 lis 2019 o 20:09 Carlos Rovira <[email protected]> >>>>> napisał(a): >>>>> >>>>> Hi, >>>>> >>>>> >>>>> >>>>> in Maven we have setup this kind of copy. So this is external process >>>>> not considered by the compiler, what seems ok, since copying that files >>>>> does not seems a competence of a compiler. Maybe that should be raised in >>>>> the IDEs issues, in this case in VSCode issues in GitHub so Josh could >>>>> express what he thinks his extension should do about this. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> El mar., 12 nov. 2019 a las 13:55, Takeshita Shoichiro (< >>>>> [email protected]>) escribió: >>>>> >>>>> I tried to build the sample project using VS Code. >>>>> >>>>> >>>>> >>>>> This one. >>>>> >>>>> >>>>> C:\apache-royale-0.9.7-bin-js\royale-asjs\examples\royale\DataGridExample >>>>> >>>>> >>>>> >>>>> I copied asconfig.json and src holder in a new folder; then build. >>>>> >>>>> >>>>> >>>>> The problem is that the image folder (resource\assets) is not copied >>>>> into bin\js-debug folder. >>>>> >>>>> >>>>> >>>>> In case using mvn clean install, the image folder is copied into the >>>>> target folder. >>>>> >>>>> >>>>> >>>>> Is this a bug or am I missing something? >>>>> >>>>> >>>>> >>>>> Shoichiro Takeshita >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Carlos Rovira >>>>> >>>>> http://about.me/carlosrovira >>>>> <https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C17b50b2b31da43bb23ac08d76963d2f2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637093749772919911&sdata=K8%2FIlPLuQFDz1R%2F4kWLDcWj6hIBVfw9PBYpq4xvlXO8%3D&reserved=0> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> *Piotr Zarzycki * >>>>> >>>>> Patreon: *https://www.patreon.com/piotrzarzycki >>>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C17b50b2b31da43bb23ac08d76963d2f2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637093749772929906&sdata=G%2BzYTqd2z2KIe9GfIV08srqi0CrB0im%2B46XD4q6jPXc%3D&reserved=0>* >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Shoichiro Takeshita >>>>> 武下 祥一郎 >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Carlos Rovira >>>>> >>>>> http://about.me/carlosrovira >>>>> <https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C17b50b2b31da43bb23ac08d76963d2f2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637093749772939896&sdata=F4s%2FMsr3z36t43hLYc59Ywuk3AxjMIOvrieCpQiJBuw%3D&reserved=0> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Shoichiro Takeshita >>>>> 武下 祥一郎 >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Shoichiro Takeshita >>>>> 武下 祥一郎 >>>>> >>>> -- >>>> Shoichiro Takeshita >>>> 武下 祥一郎 >>>> >>> >>> >>> -- >>> Carlos Rovira >>> http://about.me/carlosrovira >>> >>> >> >> -- >> Shoichiro Takeshita >> 武下 祥一郎 >> > > > -- > Shoichiro Takeshita > 武下 祥一郎 > -- Carlos Rovira http://about.me/carlosrovira
