Hi Maria Jose, can you please do a Pull Request about this tiny issue? I think is a good opportunity to try it and experience it before a bigger issue.
Let me know what you think. If you don't have time I could do it instead thanks El jue., 30 abr. 2020 a las 20:23, Maria Jose Esteve (<[email protected]>) escribió: > Hi, > The constants for icons toggle-off and toggle-on, in FontAwesome5IconType, > are TOGGLEF and TOGGLEN? > It doesn't work because they translate to "togglef" and "tooglen" instead > of "toggle-off" and "toggle-on". > > Greetings > Hiedra. > > De: Carlos Rovira <[email protected]> > Enviado el: lunes, 6 de abril de 2020 19:47 > Para: Apache Royale Development <[email protected]> > CC: [email protected] > Asunto: Re: Changes in Icon library - Support for FontAwesome > > Hi, > > just added support for version 5 (latest 5.13.0 that even has support for > latest COVIR19 icons) of FontAwesome and updated TDJ to show all the > examples. > > Things to note: > > * To add a v5 style use faStyle (Brands, Solid, Regular, Light or > Duotone) > * Added more constants where needed (i.e: ROTATE_90, SIZE_X2, > DUOTONE), if not the property will be boolean > * For FontAwesomeToggleIcon you can selected has the type > (selectedType) and the style (faSelectedStyle). > * default style is REGULAR, in toggle is SOLID > * Only type is required, is selectedType is not set fall back to type > * To use version 4 set property "v" to "4" in the icon (v is 5 by > default). Notice that FA creators doesn't recommend mix 4 and 5 icons, so > things can do unexpected results. Don't think v4 is interesting anymore. > * Since type names are change from 4 to 5, Now the Const types files > are named : FontAwesome4IconType and FontAwesome5IconType. (all const are > sort by name). > * Finally FontAwesomeIcon constructor uses an "inject_html" with the > url that's in his site [1] (like a CDN). It's working for all icons I > tested (free and pro). I saw that there's kits and tried to use it, but > this didn't work for me. So I left as is, but maybe this could need to be > revisited. For now I think is a good starting point since all seems to work > * If you see something in FontAwesome that can't be done vía current > API in Royale, please let me know, for now I think this FA support is > finished. > Thanks! > > > [1] https://pro.fontawesome.com/releases/v5.13.0/css/all.css > > > > > El mié., 1 abr. 2020 a las 3:15, Maria Jose Esteve (<[email protected] > <mailto:[email protected]>>) escribió: > It is very Good news Carlos, thk > > Hiedra. > > De: Carlos Rovira <[email protected]<mailto:[email protected] > >> > Enviado el: martes, 31 de marzo de 2020 16:43 > Para: [email protected]<mailto:[email protected]>; Apache > Royale Development <[email protected]<mailto:[email protected]>> > Asunto: Changes in Icon library - Support for FontAwesome > > Hi all, > > I added support for FontAwesome in the Icon library. > I refactored a bit to make interfaces more usable and allow other icon > sets to come later. > > Main changes are: > > * Removed "material" from IIcon interface in Core. > > * IMPORTANT: FontIcon and ToggleFontIcon are now deprecated (so please > remove it for one of the following, since I'll be removing it in the next > few days) > > * MaterialIcon and MaterialToggleIcon are now the classes to use if you > want to use material icons > > (So to update your code just replace in all your app FontIcon for > MaterialIcon and remove material=true in each instance, since is no more > needed) > > * FontAwesome and FontAwesomeToggleIcon are the classes to use if you want > to use fontawesome icons > * As MaterialIconTypes, there's a FontAwesomeIconTypes that list all the > icons in FA (I still need to check differences between version 4 and 5 and > maybe some update to names or urls will be needed to reflect that in the > next days). > * The url of the icons is now in the base class so if you are using > MaterialIcon will do the "inject_html" for the material icon font, the same > for FontAwesomeIcon. > * So ***IconTypes, does not have anymore the URL of the icon font (In this > way you don't need to use the constants class if you don't want and prefer > to type the string of the icon yourself without code hint in your IDE and > want to save some bytes). > > I still need to add some special properties of FontAwesome offers like > border, rotation and size...so consider all of this just the "preparation" > for the full support, but want to inform now about all of it. > > HTH > > -- > Carlos Rovira > http://about.me/carlosrovira > > > -- > Carlos Rovira > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
