Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: [PATCH 6/7] rt2x00: RT3593 is also applicable to USB.
(Ivo Van Doorn)
2. Re: [PATCH 7/7] rt2x00: Change RF3853 to RF3053. (Ivo Van Doorn)
3. Re: Fwd: linux-image-3.1.0-1-amd64: Can't switch off WoW
option of RT5390 wi-fi card, notebook wakes on wi-fi activity
(Ivo Van Doorn)
4. Re: [PATCH V2] rt2800usb: Move ID out of unknown (Ivo Van Doorn)
5. Re: [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding
(Andreas Hartmann)
6. Re: [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding
(Ivo Van Doorn)
7. Re: [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding
(Ivo Van Doorn)
8. Re: [PATCH 5/7] rt2x00usb: Zero USB padding before sending
URB (Ivo Van Doorn)
----------------------------------------------------------------------
Message: 1
Date: Wed, 28 Dec 2011 21:12:25 +0100
From: Ivo Van Doorn <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [rt2x00-users] [PATCH 6/7] rt2x00: RT3593 is also
applicable to USB.
Message-ID:
<CAOZOX0V4CS14MA4=1vyblwb_d5+598c__xkexgqd5skmno7...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
<[email protected]> wrote:
> Signed-off-by: Gertjan van Wingerde <[email protected]>
Acked-by: Ivo van Doorn <[email protected]>
> ---
> ?drivers/net/wireless/rt2x00/rt2x00.h | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
> b/drivers/net/wireless/rt2x00/rt2x00.h
> index 851b717..b03b22c 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> @@ -189,7 +189,7 @@ struct rt2x00_chip {
> ?#define RT3090 ? ? ? ? 0x3090 ?/* 2.4GHz PCIe */
> ?#define RT3390 ? ? ? ? 0x3390
> ?#define RT3572 ? ? ? ? 0x3572
> -#define RT3593 ? ? ? ? 0x3593 ?/* PCIe */
> +#define RT3593 ? ? ? ? 0x3593
> ?#define RT3883 ? ? ? ? 0x3883 ?/* WSOC */
> ?#define RT5390 ? ? ? ? 0x5390 ?/* 2.4GHz */
>
> --
> 1.7.7.4
>
------------------------------
Message: 2
Date: Wed, 28 Dec 2011 21:12:40 +0100
From: Ivo Van Doorn <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [rt2x00-users] [PATCH 7/7] rt2x00: Change RF3853 to
RF3053.
Message-ID:
<CAOZOX0VAvsS=yietpww+4arzpo5rceasa_kpc-w0vcm3-uw...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
<[email protected]> wrote:
> According to the latest Ralink vendor drivers, this seems to be the real
> RF chipset type.
>
> Signed-off-by: Gertjan van Wingerde <[email protected]>
Acked-by: Ivo van Doorn <[email protected]>
> ---
> ?drivers/net/wireless/rt2x00/rt2800.h | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h
> b/drivers/net/wireless/rt2x00/rt2800.h
> index 4778620..2571a2f 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -50,7 +50,7 @@
> ?* RF2853 2.4G/5G 3T3R
> ?* RF3320 2.4G 1T1R(RT3350/RT3370/RT3390)
> ?* RF3322 2.4G 2T2R(RT3352/RT3371/RT3372/RT3391/RT3392)
> - * RF3853 2.4G/5G 3T3R(RT3883/RT3563/RT3573/RT3593/RT3662)
> + * RF3053 2.4G/5G 3T3R(RT3883/RT3563/RT3573/RT3593/RT3662)
> ?* RF5370 2.4G 1T1R
> ?* RF5390 2.4G 1T1R
> ?*/
> @@ -66,7 +66,7 @@
> ?#define RF2853 ? ? ? ? ? ? ? ? ? ? ? ? 0x000a
> ?#define RF3320 ? ? ? ? ? ? ? ? ? ? ? ? 0x000b
> ?#define RF3322 ? ? ? ? ? ? ? ? ? ? ? ? 0x000c
> -#define RF3853 ? ? ? ? ? ? ? ? ? ? ? ? 0x000d
> +#define RF3053 ? ? ? ? ? ? ? ? ? ? ? ? 0x000d
> ?#define RF5370 ? ? ? ? ? ? ? ? ? ? ? ? 0x5370
> ?#define RF5390 ? ? ? ? ? ? ? ? ? ? ? ? 0x5390
>
> --
> 1.7.7.4
>
------------------------------
Message: 3
Date: Wed, 28 Dec 2011 21:14:26 +0100
From: Ivo Van Doorn <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: [email protected], pol kh <[email protected]>,
[email protected], [email protected]
Subject: Re: [rt2x00-users] Fwd: linux-image-3.1.0-1-amd64: Can't
switch off WoW option of RT5390 wi-fi card, notebook wakes on wi-fi
activity
Message-ID:
<CAOZOX0Vz1GNjnJ2z2ABd=nyff9rsiufhfwbkmxefdrvgp8l...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Wed, Dec 28, 2011 at 12:09 PM, Gertjan van Wingerde
<[email protected]> wrote:
> On 12/28/11 08:56, Helmut Schaa wrote:
>> Hi,
>>
>> Am Sonntag, 25. Dezember 2011, 09:07:42 schrieb pol kh:
>>> I'd like to be able to manage WoW option on Ralink 5390 on my HP Pavilion
>>> dv6-6030er. WoW is enabled by default in BIOS, which is locked by vendor.
>>> So I can't switch it off. Using ethtool doesn't help, because driver can't
>>> hanlder with WoW. My notebook wakes on wi-fi activity when I'd like it to
>>> be asleep. I had sent a bug report to Debian GNU/Linux maintainers and got
>>> the following answer (below my bug report is attached):
>>
>> this sounds really strange :). Unfortunately nobody is working on WoW support
>> for rt2x00 currently.
>>
>> Ivo, Gertjan, do we have any information yet how WoW for the ralink devices
>> is supposed to work? Since the WoW framework was already merged AFAIK it
>> might
>> be a trivial thing to add ...
>
> No, I've never seen any information about this.
>
> A quick look at the Ralink legacy drivers also reveal that these do not
> contain any code for this, so it will be difficult to add support for
> this in rt2x00.
Even the specsheets don't contain any reference about WoW, so I really
can't say anything about it either.
Ivo
------------------------------
Message: 4
Date: Wed, 28 Dec 2011 21:14:46 +0100
From: Ivo Van Doorn <[email protected]>
To: Larry Finger <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [rt2x00-users] [PATCH V2] rt2800usb: Move ID out of
unknown
Message-ID:
<caozox0vwb_dvvqcdzolmrn+3vy4peoo+2dnfjo356eyphaw...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
On Tue, Dec 27, 2011 at 7:22 PM, Larry Finger <[email protected]> wrote:
> Testing on the openSUSE wireless forum has shown that a Linksys
> WUSB54GC v3 with USB ID 1737:0077 works with rt2800usb when the ID is
> written to /sys/.../new_id. This ID can therefore be moved out of UNKNOWN.
>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: Stable <[email protected]>
Acked-by: Ivo van Doorn <[email protected]>
> ---
>
> V2 - Place new ID with rest of Linksys devices.
>
> Index: wireless-testing-new/drivers/net/wireless/rt2x00/rt2800usb.c
> ===================================================================
> --- wireless-testing-new.orig/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ wireless-testing-new/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -976,6 +976,7 @@ static struct usb_device_id rt2800usb_de
> ? ? ? ?{ USB_DEVICE(0x13b1, 0x0031) },
> ? ? ? ?{ USB_DEVICE(0x1737, 0x0070) },
> ? ? ? ?{ USB_DEVICE(0x1737, 0x0071) },
> + ? ? ? { USB_DEVICE(0x1737, 0x0077) },
> ? ? ? ?/* Logitec */
> ? ? ? ?{ USB_DEVICE(0x0789, 0x0162) },
> ? ? ? ?{ USB_DEVICE(0x0789, 0x0163) },
> @@ -1173,7 +1174,6 @@ static struct usb_device_id rt2800usb_de
> ? ? ? ?{ USB_DEVICE(0x1740, 0x0605) },
> ? ? ? ?{ USB_DEVICE(0x1740, 0x0615) },
> ? ? ? ?/* Linksys */
> - ? ? ? { USB_DEVICE(0x1737, 0x0077) },
> ? ? ? ?{ USB_DEVICE(0x1737, 0x0078) },
> ? ? ? ?/* Logitec */
> ? ? ? ?{ USB_DEVICE(0x0789, 0x0168) },
------------------------------
Message: 5
Date: Wed, 28 Dec 2011 23:01:20 +0100
From: Andreas Hartmann <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: [email protected], Jakub Kici?ski <[email protected]>,
[email protected]
Subject: Re: [rt2x00-users] [PATCH 4/7] rt2800usb: Let rt2x00usb
handle USB padding
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-2
Gertjan van Wingerde schrieb:
> On 12/28/11 21:12, Ivo Van Doorn wrote:
>> On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
>> <[email protected]> wrote:
>>> From: Jakub Kici?ski <[email protected]>
>>>
>>> Older USB drivers does not append end padding to skb but instead report
>>> it in size of data to be transmitted to HW. rt2800usb should follow that
>>> behaviour. Custom write_tx_data callback which was adding pad to skb
>>> is not be needed any more.
>>>
>>> Thanks to this patch frames handed back from rt2800usb to mac80211 will
>>> no longer contain end padding.
>>
>> What happened to the reports that after this (and the next) patch, the
>> non-2800 USB
>> drivers are failing?
>
> I have seen only 1 failure report (from Andreas Hartmann), which seemed
> to have been caused by not applying both patches. ISTR that Andreas did
> not see any regression when both patches were applied.
Yes, that's true. The behavior of a rt3572 dongle in my test with both
patches applied was the same as without these both patches.
Please note that the test I did was very short, because the rt2800usb
driver works really bad with this device anyway.
Kind regards,
Andreas Hartmann
------------------------------
Message: 6
Date: Wed, 28 Dec 2011 23:40:13 +0100
From: Ivo Van Doorn <[email protected]>
To: Andreas Hartmann <[email protected]>
Cc: [email protected], Jakub Kici?ski <[email protected]>,
[email protected]
Subject: Re: [rt2x00-users] [PATCH 4/7] rt2800usb: Let rt2x00usb
handle USB padding
Message-ID:
<CAOZOX0V5V6O=GDydjmxn2YGAJGwqT5GU8GqVeshdbe=mjt4...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-2
2011/12/28 Andreas Hartmann <[email protected]>:
> Gertjan van Wingerde schrieb:
>> On 12/28/11 21:12, Ivo Van Doorn wrote:
>>> On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
>>> <[email protected]> wrote:
>>>> From: Jakub Kici?ski <[email protected]>
>>>>
>>>> Older USB drivers does not append end padding to skb but instead report
>>>> it in size of data to be transmitted to HW. rt2800usb should follow that
>>>> behaviour. Custom write_tx_data callback which was adding pad to skb
>>>> is not be needed any more.
>>>>
>>>> Thanks to this patch frames handed back from rt2800usb to mac80211 will
>>>> no longer contain end padding.
>>>
>>> What happened to the reports that after this (and the next) patch, the
>>> non-2800 USB
>>> drivers are failing?
>>
>> I have seen only 1 failure report (from Andreas Hartmann), which seemed
>> to have been caused by not applying both patches. ISTR that Andreas did
>> not see any regression when both patches were applied.
>
> Yes, that's true. The behavior of a rt3572 dongle in my test with both
> patches applied was the same as without these both patches.
>
> Please note that the test I did was very short, because the rt2800usb
> driver works really bad with this device anyway.
Ok, thanks for the update.
Ivo
------------------------------
Message: 7
Date: Wed, 28 Dec 2011 23:40:35 +0100
From: Ivo Van Doorn <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: Jakub Kici?ski <[email protected]>, [email protected],
[email protected]
Subject: Re: [rt2x00-users] [PATCH 4/7] rt2800usb: Let rt2x00usb
handle USB padding
Message-ID:
<CAOZOX0UnBzt+=c_9AEZEsuOxZmJyGsQDZkLsadj7R+a=e3z...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-2
On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
<[email protected]> wrote:
> From: Jakub Kici?ski <[email protected]>
>
> Older USB drivers does not append end padding to skb but instead report
> it in size of data to be transmitted to HW. rt2800usb should follow that
> behaviour. Custom write_tx_data callback which was adding pad to skb
> is not be needed any more.
>
> Thanks to this patch frames handed back from rt2800usb to mac80211 will
> no longer contain end padding.
>
> Signed-off-by: Jakub Kicinski <[email protected]>
> Signed-off-by: Gertjan van Wingerde <[email protected]>
Acked-by: Ivo van Doorn <[email protected]>
> ---
> ?drivers/net/wireless/rt2x00/rt2800usb.c | ? 37 ++++++++----------------------
> ?1 files changed, 10 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
> b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 313cc7f..b15c215 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -400,10 +400,10 @@ static void rt2800usb_write_tx_desc(struct queue_entry
> *entry,
> ? ? ? ?/*
> ? ? ? ? * The size of TXINFO_W0_USB_DMA_TX_PKT_LEN is
> ? ? ? ? * TXWI + 802.11 header + L2 pad + payload + pad,
> - ? ? ? ?* so need to decrease size of TXINFO and USB end pad.
> + ? ? ? ?* so need to decrease size of TXINFO.
> ? ? ? ? */
> ? ? ? ?rt2x00_set_field32(&word, TXINFO_W0_USB_DMA_TX_PKT_LEN,
> - ? ? ? ? ? ? ? ? ? ? ? ? ?entry->skb->len - TXINFO_DESC_SIZE - 4);
> + ? ? ? ? ? ? ? ? ? ? ? ? ?roundup(entry->skb->len, 4) - TXINFO_DESC_SIZE);
> ? ? ? ?rt2x00_set_field32(&word, TXINFO_W0_WIV,
> ? ? ? ? ? ? ? ? ? ? ? ? ? !test_bit(ENTRY_TXD_ENCRYPT_IV, &txdesc->flags));
> ? ? ? ?rt2x00_set_field32(&word, TXINFO_W0_QSEL, 2);
> @@ -421,37 +421,20 @@ static void rt2800usb_write_tx_desc(struct queue_entry
> *entry,
> ? ? ? ?skbdesc->desc_len = TXINFO_DESC_SIZE + TXWI_DESC_SIZE;
> ?}
>
> -static void rt2800usb_write_tx_data(struct queue_entry *entry,
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct txentry_desc *txdesc)
> +/*
> + * TX data initialization
> + */
> +static int rt2800usb_get_tx_data_len(struct queue_entry *entry)
> ?{
> - ? ? ? unsigned int len;
> - ? ? ? int err;
> -
> - ? ? ? rt2800_write_tx_data(entry, txdesc);
> -
> ? ? ? ?/*
> - ? ? ? ?* pad(1~3 bytes) is added after each 802.11 payload.
> - ? ? ? ?* USB end pad(4 bytes) is added at each USB bulk out packet end.
> + ? ? ? ?* pad(1~3 bytes) is needed after each 802.11 payload.
> + ? ? ? ?* USB end pad(4 bytes) is needed at each USB bulk out packet end.
> ? ? ? ? * TX frame format is :
> ? ? ? ? * | TXINFO | TXWI | 802.11 header | L2 pad | payload | pad | USB end
> pad |
> ? ? ? ? * ? ? ? ? ? ? ? ? |<------------- tx_pkt_len ------------->|
> ? ? ? ? */
> - ? ? ? len = roundup(entry->skb->len, 4) + 4;
> - ? ? ? err = skb_padto(entry->skb, len);
> - ? ? ? if (unlikely(err)) {
> - ? ? ? ? ? ? ? WARNING(entry->queue->rt2x00dev, "TX SKB padding error, out
> of memory\n");
> - ? ? ? ? ? ? ? return;
> - ? ? ? }
>
> - ? ? ? entry->skb->len = len;
> -}
> -
> -/*
> - * TX data initialization
> - */
> -static int rt2800usb_get_tx_data_len(struct queue_entry *entry)
> -{
> - ? ? ? return entry->skb->len;
> + ? ? ? return roundup(entry->skb->len, 4) + 4;
> ?}
>
> ?/*
> @@ -807,7 +790,7 @@ static const struct rt2x00lib_ops rt2800usb_rt2x00_ops = {
> ? ? ? ?.flush_queue ? ? ? ? ? ?= rt2x00usb_flush_queue,
> ? ? ? ?.tx_dma_done ? ? ? ? ? ?= rt2800usb_tx_dma_done,
> ? ? ? ?.write_tx_desc ? ? ? ? ?= rt2800usb_write_tx_desc,
> - ? ? ? .write_tx_data ? ? ? ? ?= rt2800usb_write_tx_data,
> + ? ? ? .write_tx_data ? ? ? ? ?= rt2800_write_tx_data,
> ? ? ? ?.write_beacon ? ? ? ? ? = rt2800_write_beacon,
> ? ? ? ?.clear_beacon ? ? ? ? ? = rt2800_clear_beacon,
> ? ? ? ?.get_tx_data_len ? ? ? ?= rt2800usb_get_tx_data_len,
> --
> 1.7.7.4
>
------------------------------
Message: 8
Date: Wed, 28 Dec 2011 23:40:52 +0100
From: Ivo Van Doorn <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: Jakub Kici?ski <[email protected]>, [email protected],
[email protected]
Subject: Re: [rt2x00-users] [PATCH 5/7] rt2x00usb: Zero USB padding
before sending URB
Message-ID:
<CAOZOX0U4x8OaX=XLGbPy5wMMhm_=firqulol2hh048qgang...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
<[email protected]> wrote:
> From: Jakub Kici?ski <[email protected]>
>
> When USB driver requires padding at the end of frame or URB it will report
> this need by increasing return value of get_tx_data_len callback. Common
> USB code uses that return value as desired URB length.
>
> Ensure that appropriate part of skb's tailroom exists and is zeroed.
>
> Signed-off-by: Jakub Kicinski <[email protected]>
Acked-by: Ivo van Doorn <[email protected]>
> --
> ?drivers/net/wireless/rt2x00/rt2x00usb.c | ? 16 +++++++++++++---
> ?1 files changed, 13 insertions(+), 3 deletions(-)
> Signed-off-by: Gertjan van Wingerde <[email protected]>
> ---
> ?drivers/net/wireless/rt2x00/rt2x00usb.c | ? 16 +++++++++++++---
> ?1 files changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c
> b/drivers/net/wireless/rt2x00/rt2x00usb.c
> index 1e31050..2eea386 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00usb.c
> @@ -298,12 +298,22 @@ static bool rt2x00usb_kick_tx_entry(struct queue_entry
> *entry, void* data)
> ? ? ? ? ? ? ? ?return false;
>
> ? ? ? ?/*
> - ? ? ? ?* USB devices cannot blindly pass the skb->len as the
> - ? ? ? ?* length of the data to usb_fill_bulk_urb. Pass the skb
> - ? ? ? ?* to the driver to determine what the length should be.
> + ? ? ? ?* USB devices require certain padding at the end of each frame
> + ? ? ? ?* and urb. Those paddings are not included in skbs. Pass entry
> + ? ? ? ?* to the driver to determine what the overall length should be.
> ? ? ? ? */
> ? ? ? ?length = rt2x00dev->ops->lib->get_tx_data_len(entry);
>
> + ? ? ? status = skb_padto(entry->skb, length);
> + ? ? ? if (unlikely(status)) {
> + ? ? ? ? ? ? ? /* TODO: report something more appropriate than IO_FAILED. */
> + ? ? ? ? ? ? ? WARNING(rt2x00dev, "TX SKB padding error, out of memory\n");
> + ? ? ? ? ? ? ? set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
> + ? ? ? ? ? ? ? rt2x00lib_dmadone(entry);
> +
> + ? ? ? ? ? ? ? return false;
> + ? ? ? }
> +
> ? ? ? ?usb_fill_bulk_urb(entry_priv->urb, usb_dev,
> ? ? ? ? ? ? ? ? ? ? ? ? ?usb_sndbulkpipe(usb_dev, entry->queue->usb_endpoint),
> ? ? ? ? ? ? ? ? ? ? ? ? ?entry->skb->data, length,
> --
> 1.7.7.4
>
------------------------------
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
End of users Digest, Vol 34, Issue 17
*************************************
