Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. [PATCH] rt2x00pci: Use PCI MSIs whenever possible (Jakub Kicinski)
2. [PATCH] rt2x00/rt3352: Fix lnagain assignment to use register
66 (Daniel Golle)
----------------------------------------------------------------------
Message: 1
Date: Wed, 3 Oct 2012 21:32:38 +0200
From: Jakub Kicinski <[email protected]>
To: Ivo Van Doorn <[email protected]>, Gertjan van Wingerde
<[email protected]>, Stanislaw Gruszka <[email protected]>
Cc: Jakub Kicinski <[email protected]>, [email protected]
Subject: [rt2x00-users] [PATCH] rt2x00pci: Use PCI MSIs whenever
possible
Message-ID: <[email protected]>
All PCIe devices must support MSIs, make use of them.
Signed-off-by: Jakub Kicinski <[email protected]>
---
Hi,
just a little tweak. I think MSIs should work just ok,
as legacy driver is using them.
I will repost this to linux-wireless if I have your ack's.
drivers/net/wireless/rt2x00/rt2x00pci.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c
b/drivers/net/wireless/rt2x00/rt2x00pci.c
index a0c8cae..7eb500a 100644
--- a/drivers/net/wireless/rt2x00/rt2x00pci.c
+++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
@@ -281,11 +281,13 @@ int rt2x00pci_probe(struct pci_dev *pci_dev, const struct
rt2x00_ops *ops)
goto exit_release_regions;
}
+ pci_enable_msi(pci_dev);
+
hw = ieee80211_alloc_hw(sizeof(struct rt2x00_dev), ops->hw);
if (!hw) {
ERROR_PROBE("Failed to allocate hardware.\n");
retval = -ENOMEM;
- goto exit_release_regions;
+ goto exit_disable_msi;
}
pci_set_drvdata(pci_dev, hw);
@@ -326,6 +328,9 @@ exit_free_reg:
exit_free_device:
ieee80211_free_hw(hw);
+exit_disable_msi:
+ pci_disable_msi(pci_dev);
+
exit_release_regions:
pci_release_regions(pci_dev);
@@ -350,6 +355,8 @@ void rt2x00pci_remove(struct pci_dev *pci_dev)
rt2x00pci_free_reg(rt2x00dev);
ieee80211_free_hw(hw);
+ pci_disable_msi(pci_dev);
+
/*
* Free the PCI device data.
*/
--
1.7.11.4
------------------------------
Message: 2
Date: Thu, 4 Oct 2012 00:38:49 +0200
From: Daniel Golle <[email protected]>
To: <[email protected]>
Subject: [rt2x00-users] [PATCH] rt2x00/rt3352: Fix lnagain assignment
to use register 66
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
This should be register 66 instead of 62.
(probably happened by copy&past'ing from the lines below)
Signed-off-by: Daniel Golle <[email protected]>
---
drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
b/drivers/net/wireless/rt2x00/rt2800lib.c
index 540c94f..01dc889 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -2252,9 +2252,9 @@ static void rt2800_config_channel(struct rt2x00_dev
*rt2x00dev,
*/
if (rt2x00_rt(rt2x00dev, RT3352)) {
rt2800_bbp_write(rt2x00dev, 27, 0x0);
- rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+ rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
rt2800_bbp_write(rt2x00dev, 27, 0x20);
- rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+ rt2800_bbp_write(rt2x00dev, 66, 0x26 + rt2x00dev->lna_gain);
} else {
rt2800_bbp_write(rt2x00dev, 62, 0x37 - rt2x00dev->lna_gain);
rt2800_bbp_write(rt2x00dev, 63, 0x37 - rt2x00dev->lna_gain);
--
1.7.12.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/attachments/20121004/09d7eebf/attachment-0001.bin>
------------------------------
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
End of users Digest, Vol 44, Issue 2
************************************
