Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: [PATCH] rt2x00: rt2800lib: remove trailing semicolons
from RFCSR3_* defines (Gertjan van Wingerde)
2. Re: [PATCH] rt2x00: rt2800lib: introduce RFCSR3_VCOCAL_EN
(Gertjan van Wingerde)
----------------------------------------------------------------------
Message: 1
Date: Sun, 2 Dec 2012 22:31:23 +0000
From: Gertjan van Wingerde <[email protected]>
To: Gabor Juhos <[email protected]>
Cc: Gabor Juhos <[email protected]>, "[email protected]"
<[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: rt2800lib: remove trailing
semicolons from RFCSR3_* defines
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 2 dec. 2012, at 16:24, Gabor Juhos <[email protected]> wrote:
> Signed-off-by: Gabor Juhos <[email protected]>
Ouch, that could have led to some nasty bugs. Thanks for spotting this and
sending the patch.
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h
> b/drivers/net/wireless/rt2x00/rt2800.h
> index 6d67c3e..1157b06 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
> */
> #define RFCSR3_K FIELD8(0x0f)
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> -#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
> -#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
> +#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> +#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
>
> /*
> * FRCSR 5:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Message: 2
Date: Sun, 2 Dec 2012 22:33:12 +0000
From: Gertjan van Wingerde <[email protected]>
To: Gabor Juhos <[email protected]>
Cc: Gabor Juhos <[email protected]>, "[email protected]"
<[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: rt2800lib: introduce
RFCSR3_VCOCAL_EN
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 2 dec. 2012, at 17:34, Gabor Juhos <[email protected]> wrote:
> On the RF3290,RF5360,RF5370,RF5372,RF5390,RF5392
> radio frontends, the VCO calibration can be
> controlled via the RFCSR3 register. The current
> code uses the RFCSR30_RF_CALIBRATION constant to
> enable the calibration, however that belongs to
> the RFCSR30 register. Although the values of the
> constant is correct, but using that for another
> register is confusing.
>
> Add a new definition for the VCO calibration enable
> bit of the RFCSR3 register and use that in the
> relevant places in order to avoid confusions.
>
> The patch contains no functional changes.
>
> Signed-off-by: Gabor Juhos <[email protected]>
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
> This depends on the following patch:
> 'rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines'
>
> drivers/net/wireless/rt2x00/rt2800.h | 2 ++
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h
> b/drivers/net/wireless/rt2x00/rt2800.h
> index 1157b06..4db1088 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1995,6 +1995,8 @@ struct mac_iveiv_entry {
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> #define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> #define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
> +/* Bits for RF3290/RF5360/RF5370/RF5372/RF5390/RF5392 */
> +#define RFCSR3_VCOCAL_EN FIELD8(0x80)
>
> /*
> * FRCSR 5:
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
> b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 1cc6599..d4d0c36 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2243,7 +2243,7 @@ static void rt2800_config_channel(struct rt2x00_dev
> *rt2x00dev,
> rt2800_rfcsr_write(rt2x00dev, 30, rfcsr);
>
> rt2800_rfcsr_read(rt2x00dev, 3, &rfcsr);
> - rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 1);
> + rt2x00_set_field8(&rfcsr, RFCSR3_VCOCAL_EN, 1);
> rt2800_rfcsr_write(rt2x00dev, 3, rfcsr);
> }
>
> @@ -2804,7 +2804,7 @@ void rt2800_vco_calibration(struct rt2x00_dev
> *rt2x00dev)
> case RF5390:
> case RF5392:
> rt2800_rfcsr_read(rt2x00dev, 3, &rfcsr);
> - rt2x00_set_field8(&rfcsr, RFCSR30_RF_CALIBRATION, 1);
> + rt2x00_set_field8(&rfcsr, RFCSR3_VCOCAL_EN, 1);
> rt2800_rfcsr_write(rt2x00dev, 3, rfcsr);
> break;
> default:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 46, Issue 5
************************************
